isapnp: broken API

isapnp: broken API

[Sacher Khoudari]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

Hi!

I've lately tried to run a ISA card (HP 82341, with drivers from the  
Linux GPIB project, latest version), but the module failed to get  
loaded. Modprobe said it couldn't find a symbol (Undefined symbol  
'isapnp_read_byte'), although it was present in /boot/System.map and  
/proc/kallsyms. After some googleing, trying to compile a new kernel,  
looking into code, etc, I found out what the problem was. The function  
"isapnp_read_byte" was no longer been exported. You can find the line  
in question here [1] (note the #if 0). The patch that did this change  
was this [2] one.

I'm not sure, but as I understand it, it was not intended to comment  
this EXPORT_SYMBOLS(isapnp_read_byte) out. So it probably just  
happened by accident?

I've attached a patch for the latest stable kernel (2.6.20.1). Please  
apply it.


Greetings
Sacher



[1] http://www.gelato.unsw.edu.au/lxr/source/drivers/pnp/isapnp/core.c#L948
[2] http://lkml.org/lkml/2005/6/20/307

[-- Attachment #2: isapnp.patch --]
[-- Type: text/x-patch, Size: 457 bytes --]

--- linux-2.6.20.1/drivers/pnp/isapnp/core.c.old	2007-02-23 16:20:46.000000000 +0100
+++ linux-2.6.20.1/drivers/pnp/isapnp/core.c	2007-02-23 16:21:25.000000000 +0100
@@ -943,9 +943,7 @@
 EXPORT_SYMBOL(isapnp_present);
 EXPORT_SYMBOL(isapnp_cfg_begin);
 EXPORT_SYMBOL(isapnp_cfg_end);
-#if 0
 EXPORT_SYMBOL(isapnp_read_byte);
-#endif
 EXPORT_SYMBOL(isapnp_write_byte);
 
 static int isapnp_read_resources(struct pnp_dev *dev, struct pnp_resource_table *res)

Re: isapnp: broken API

[Alexey Dobriyan]

On Fri, Feb 23, 2007 at 04:25:05PM +0100, Sacher Khoudari wrote:
> I've lately tried to run a ISA card (HP 82341, with drivers from the
> Linux GPIB project, latest version), but the module failed to get
> loaded. Modprobe said it couldn't find a symbol (Undefined symbol
> 'isapnp_read_byte'), although it was present in /boot/System.map and
> /proc/kallsyms. After some googleing, trying to compile a new kernel,
> looking into code, etc, I found out what the problem was. The function
> "isapnp_read_byte" was no longer been exported. You can find the line
> in question here [1] (note the #if 0). The patch that did this change
> was this [2] one.
>
> I'm not sure, but as I understand it, it was not intended to comment
> this EXPORT_SYMBOLS(isapnp_read_byte) out. So it probably just
> happened by accident?

No. It was unexported because no modular code in mainline was using it.

> [1] http://www.gelato.unsw.edu.au/lxr/source/drivers/pnp/isapnp/core.c#L948
> [2] http://lkml.org/lkml/2005/6/20/307

> --- linux-2.6.20.1/drivers/pnp/isapnp/core.c.old
> +++ linux-2.6.20.1/drivers/pnp/isapnp/core.c
> @@ -943,9 +943,7 @@
>  EXPORT_SYMBOL(isapnp_present);
>  EXPORT_SYMBOL(isapnp_cfg_begin);
>  EXPORT_SYMBOL(isapnp_cfg_end);
> -#if 0
>  EXPORT_SYMBOL(isapnp_read_byte);
> -#endif
>  EXPORT_SYMBOL(isapnp_write_byte);

Re: isapnp: broken API

[Andrew Morton]

> On Fri, 23 Feb 2007 16:25:05 +0100 Sacher Khoudari <Sacher.Khoudari@stud.uni-heidelberg.de> wrote:
> --- linux-2.6.20.1/drivers/pnp/isapnp/core.c.old	2007-02-23 16:20:46.000000000 +0100
> +++ linux-2.6.20.1/drivers/pnp/isapnp/core.c	2007-02-23 16:21:25.000000000 +0100
> @@ -943,9 +943,7 @@
>  EXPORT_SYMBOL(isapnp_present);
>  EXPORT_SYMBOL(isapnp_cfg_begin);
>  EXPORT_SYMBOL(isapnp_cfg_end);
> -#if 0
>  EXPORT_SYMBOL(isapnp_read_byte);
> -#endif
>  EXPORT_SYMBOL(isapnp_write_byte);

Yeah, that was a rather silly unexport.  I'll apply this, thanks.