* [PATCH] kprobes: fix sparse NULL warning
@ 2007-03-17 1:34 Randy Dunlap
2007-03-17 5:37 ` Ananth N Mavinakayanahalli
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2007-03-17 1:34 UTC (permalink / raw)
To: prasanna, ananth, anil.s.keshavamurthy, davem; +Cc: lkml
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix sparse NULL warnings:
kernel/kprobes.c:915:49: warning: Using plain integer as NULL pointer
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
kernel/kprobes.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2621-rc4.orig/kernel/kprobes.c
+++ linux-2621-rc4/kernel/kprobes.c
@@ -35,6 +35,7 @@
#include <linux/hash.h>
#include <linux/init.h>
#include <linux/slab.h>
+#include <linux/stddef.h>
#include <linux/module.h>
#include <linux/moduleloader.h>
#include <linux/kallsyms.h>
@@ -912,7 +913,7 @@ static int __kprobes debugfs_kprobe_init
if (!dir)
return -ENOMEM;
- file = debugfs_create_file("list", 0444, dir , 0 ,
+ file = debugfs_create_file("list", 0444, dir, NULL,
&debugfs_kprobes_operations);
if (!file) {
debugfs_remove(dir);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] kprobes: fix sparse NULL warning
2007-03-17 1:34 [PATCH] kprobes: fix sparse NULL warning Randy Dunlap
@ 2007-03-17 5:37 ` Ananth N Mavinakayanahalli
0 siblings, 0 replies; 2+ messages in thread
From: Ananth N Mavinakayanahalli @ 2007-03-17 5:37 UTC (permalink / raw)
To: Randy Dunlap; +Cc: prasanna, anil.s.keshavamurthy, davem, lkml
On Fri, Mar 16, 2007 at 06:34:36PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix sparse NULL warnings:
> kernel/kprobes.c:915:49: warning: Using plain integer as NULL pointer
Thanks for catching this Randy.
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> ---
> kernel/kprobes.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2621-rc4.orig/kernel/kprobes.c
> +++ linux-2621-rc4/kernel/kprobes.c
> @@ -35,6 +35,7 @@
> #include <linux/hash.h>
> #include <linux/init.h>
> #include <linux/slab.h>
> +#include <linux/stddef.h>
> #include <linux/module.h>
> #include <linux/moduleloader.h>
> #include <linux/kallsyms.h>
> @@ -912,7 +913,7 @@ static int __kprobes debugfs_kprobe_init
> if (!dir)
> return -ENOMEM;
>
> - file = debugfs_create_file("list", 0444, dir , 0 ,
> + file = debugfs_create_file("list", 0444, dir, NULL,
> &debugfs_kprobes_operations);
> if (!file) {
> debugfs_remove(dir);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-17 5:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-17 1:34 [PATCH] kprobes: fix sparse NULL warning Randy Dunlap
2007-03-17 5:37 ` Ananth N Mavinakayanahalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox