The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] kbuild: move tags from ARCH and include/ ahead of drivers
@ 2007-01-04 18:14 Don Mullis
  2007-03-17  8:35 ` Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Don Mullis @ 2007-01-04 18:14 UTC (permalink / raw)
  To: lkml, kbuild-devel; +Cc: kai, sam

Move tags extracted from the ARCH and include/ sub-trees ahead of
those from device drivers, so that the former will appear first
during searches. 

Saves user time during interactive searches for certain patterns
that happen to find unwanted matches in driver files.

Example in emacs:
	 "M-x find-tag PAGE_SIZE"
	 "M-1 M-." (repeated until definition from asm-i386/page.h appears)

Signed-off-by: Don Mullis <dwm@meer.net>
---
Tested with emacs/etags/ctags v22.0.92 by:
 1) running `make TAGS`, `make tags` with and without patch (ARCH=i386).
 2) verifying improved behavior of tag definition searching with
   "M-x find-tag PAGE_SIZE", "M-1 M-." in emacs

 Makefile |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Index: linux-2.6.19/Makefile
===================================================================
--- linux-2.6.19.orig/Makefile
+++ linux-2.6.19/Makefile
@@ -1292,10 +1292,7 @@ endif
 ALLSOURCE_ARCHS := $(ARCH)
 
 define find-sources
-        ( find $(__srctree) $(RCS_FIND_IGNORE) \
-	       \( -name include -o -name arch \) -prune -o \
-	       -name $1 -print; \
-	  for ARCH in $(ALLSOURCE_ARCHS) ; do \
+        ( for ARCH in $(ALLSOURCE_ARCHS) ; do \
 	       find $(__srctree)arch/$${ARCH} $(RCS_FIND_IGNORE) \
 	            -name $1 -print; \
 	  done ; \
@@ -1309,7 +1306,11 @@ define find-sources
 	            -name $1 -print; \
 	  done ; \
 	  find $(__srctree)include/asm-generic $(RCS_FIND_IGNORE) \
-	       -name $1 -print )
+	       -name $1 -print; \
+	  find $(__srctree) $(RCS_FIND_IGNORE) \
+	       \( -name include -o -name arch \) -prune -o \
+	       -name $1 -print; \
+	  )
 endef
 
 define all-sources



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kbuild: move tags from ARCH and include/ ahead of drivers
  2007-01-04 18:14 [PATCH] kbuild: move tags from ARCH and include/ ahead of drivers Don Mullis
@ 2007-03-17  8:35 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2007-03-17  8:35 UTC (permalink / raw)
  To: Don Mullis; +Cc: lkml, kbuild-devel, kai

On Thu, Jan 04, 2007 at 10:14:52AM -0800, Don Mullis wrote:
> Move tags extracted from the ARCH and include/ sub-trees ahead of
> those from device drivers, so that the former will appear first
> during searches. 
> 
> Saves user time during interactive searches for certain patterns
> that happen to find unwanted matches in driver files.
> 
> Example in emacs:
> 	 "M-x find-tag PAGE_SIZE"
> 	 "M-1 M-." (repeated until definition from asm-i386/page.h appears)
> 
> Signed-off-by: Don Mullis <dwm@meer.net>

Applied, thanks.

	Sam

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-03-17  8:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-04 18:14 [PATCH] kbuild: move tags from ARCH and include/ ahead of drivers Don Mullis
2007-03-17  8:35 ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox