From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, viro@ftp.linux.org.uk,
linuxram@us.ibm.com, ebiederm@xmission.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
containers@lists.osdl.org
Subject: Re: [patch 05/10] Add "permit user submounts" flag to vfsmount
Date: Tue, 17 Apr 2007 09:33:01 -0500 [thread overview]
Message-ID: <20070417143301.GH1442@sergelap.austin.ibm.com> (raw)
In-Reply-To: <E1HdlAt-00013a-00@dorka.pomaz.szeredi.hu>
Quoting Miklos Szeredi (miklos@szeredi.hu):
> > > From: Miklos Szeredi <mszeredi@suse.cz>
> > >
> > > If MNT_USERMNT flag is not set in the target vfsmount, then
> >
> > MNT_USER and MNT_USERMNT? I claim no way will people keep those
> > straight. How about MNT_ALLOWUSER and MNT_USER?
>
> Umm, is "allowuser" more clear than "usermnt"? What is allowed to the
I think so, yes. One makes it clear that we're talking about allowing
user (somethings :), one might just as well mean "this is a user mount."
> user? "allowusermnt" may be more descriptive, but it's a bit too
> long.
Yes, if it weren't too long it would by far have been my preference.
Maybe despite the length we should still go with it...
> I don't think it matters all that much, the user will have to look up
> the semantics in the manpage anyway. Is "nosuid" descriptive? Not
> very much, but we got used to it.
nosuid is quite clear. MNT_USER and MNT_USERMNT are so confusing that
in the time I go from quitting the manpage to foregrounding my editor, I
may have already forgotten which was which.
-serge
next prev parent reply other threads:[~2007-04-17 14:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 11:03 [patch 00/10] mount ownership and unprivileged mount syscall (v3) Miklos Szeredi
2007-04-16 11:03 ` [patch 01/10] add user mounts to the kernel Miklos Szeredi
2007-04-16 11:03 ` [patch 02/10] allow unprivileged umount Miklos Szeredi
2007-04-16 19:39 ` Eric W. Biederman
2007-04-16 19:58 ` Greg KH
2007-04-16 11:03 ` [patch 03/10] account user mounts Miklos Szeredi
2007-04-16 11:03 ` [patch 04/10] allow per-mount flags to be set/cleared individually Miklos Szeredi
2007-04-16 11:03 ` [patch 05/10] Add "permit user submounts" flag to vfsmount Miklos Szeredi
2007-04-16 19:20 ` Serge E. Hallyn
2007-04-17 10:44 ` Miklos Szeredi
2007-04-17 14:33 ` Serge E. Hallyn [this message]
2007-04-17 16:08 ` Miklos Szeredi
2007-04-17 16:54 ` Serge E. Hallyn
2007-04-16 11:03 ` [patch 06/10] propagate error values from clone_mnt Miklos Szeredi
2007-04-16 11:03 ` [patch 07/10] allow unprivileged bind mounts Miklos Szeredi
2007-04-16 11:03 ` [patch 08/10] put declaration of put_filesystem() in fs.h Miklos Szeredi
2007-04-16 11:03 ` [patch 09/10] allow unprivileged mounts Miklos Szeredi
2007-04-16 11:03 ` [patch 10/10] allow unprivileged fuse mounts Miklos Szeredi
2007-04-18 7:08 ` [patch 00/10] mount ownership and unprivileged mount syscall (v3) Jeremy Maitin-Shepard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417143301.GH1442@sergelap.austin.ibm.com \
--to=serue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=miklos@szeredi.hu \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox