From: Andrew Morton <akpm@linux-foundation.org>
To: Balbir Singh <balbir@in.ibm.com>
Cc: nagar@watson.ibm.com, jlan@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] Taskstats fix the structure members alignment issue
Date: Fri, 20 Apr 2007 12:15:43 -0700 [thread overview]
Message-ID: <20070420121543.6a1a8426.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070420164341.14718.5013.sendpatchset@balbir-laptop>
On Fri, 20 Apr 2007 22:13:41 +0530
Balbir Singh <balbir@in.ibm.com> wrote:
>
> We broke the the alignment of members of taskstats to the 8 byte boundary
> with the CSA patches. In the current kernel, the taskstats structure is
> not suitable for use by 32 bit applications in a 64 bit kernel.
>
ugh, that was bad of us.
> ...
> The patch adds an __attribute__((aligned(8))) to the
> taskstats structure members so that 32 bit applications using taskstats
> can work with a 64 bit kernel.
But there might be 32-bit applications out there which are using the
present wrong structure?
otoh, I assume that those applications would be using taskstats.h and would
hence encounter this bug and we would have heard about it, is that correct?
otoh^2, 32-bit applications running under 32-bit kernels will presently be
functioning correctly, and your change will require that those applications
be recompiled, I think?
This patch looks like 2.6.20 and 2.6.21 material, but very carefully...
next prev parent reply other threads:[~2007-04-20 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 16:43 [PATCH -mm] Taskstats fix the structure members alignment issue Balbir Singh
2007-04-20 19:15 ` Andrew Morton [this message]
2007-04-21 12:59 ` Balbir Singh
2007-04-21 19:33 ` Andrew Morton
2007-04-22 5:00 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070420121543.6a1a8426.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=jlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nagar@watson.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox