* [PATCH] slub: remove duplicate VM_BUG_ON
@ 2007-05-02 20:08 Pekka J Enberg
2007-05-02 20:12 ` Christoph Lameter
0 siblings, 1 reply; 6+ messages in thread
From: Pekka J Enberg @ 2007-05-02 20:08 UTC (permalink / raw)
To: akpm; +Cc: clameter, linux-kernel
From: Pekka Enberg <penberg@cs.helsinki.fi>
This patch removes a duplicate VM_BUG_ON from add_full().
Cc: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
mm/slub.c | 2 --
1 file changed, 2 deletions(-)
Index: 26-mm/mm/slub.c
===================================================================
--- 26-mm.orig/mm/slub.c 2007-05-02 23:00:58.000000000 +0300
+++ 26-mm/mm/slub.c 2007-05-02 23:01:15.000000000 +0300
@@ -633,8 +633,6 @@ static void add_full(struct kmem_cache *
VM_BUG_ON(!irqs_disabled());
- VM_BUG_ON(!irqs_disabled());
-
if (!(s->flags & SLAB_STORE_USER))
return;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] slub: remove duplicate VM_BUG_ON
2007-05-02 20:08 [PATCH] slub: remove duplicate VM_BUG_ON Pekka J Enberg
@ 2007-05-02 20:12 ` Christoph Lameter
2007-05-02 20:21 ` Pekka Enberg
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Lameter @ 2007-05-02 20:12 UTC (permalink / raw)
To: Pekka J Enberg; +Cc: akpm, linux-kernel
Patch is already in mm. Could you download all the patches after that
before testing? There was quite a number.
On Wed, 2 May 2007, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> This patch removes a duplicate VM_BUG_ON from add_full().
>
> Cc: Christoph Lameter <clameter@sgi.com>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> ---
> mm/slub.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: 26-mm/mm/slub.c
> ===================================================================
> --- 26-mm.orig/mm/slub.c 2007-05-02 23:00:58.000000000 +0300
> +++ 26-mm/mm/slub.c 2007-05-02 23:01:15.000000000 +0300
> @@ -633,8 +633,6 @@ static void add_full(struct kmem_cache *
>
> VM_BUG_ON(!irqs_disabled());
>
> - VM_BUG_ON(!irqs_disabled());
> -
> if (!(s->flags & SLAB_STORE_USER))
> return;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] slub: remove duplicate VM_BUG_ON
2007-05-02 20:12 ` Christoph Lameter
@ 2007-05-02 20:21 ` Pekka Enberg
2007-05-02 21:14 ` Christoph Lameter
0 siblings, 1 reply; 6+ messages in thread
From: Pekka Enberg @ 2007-05-02 20:21 UTC (permalink / raw)
To: Christoph Lameter; +Cc: akpm, linux-kernel
Christoph Lameter wrote:
> Patch is already in mm. Could you download all the patches after that
> before testing? There was quite a number.
I am on 2.6.21-rc7-mm2. Me goes to wonder where Andrew's snapshots are...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] slub: remove duplicate VM_BUG_ON
2007-05-02 20:21 ` Pekka Enberg
@ 2007-05-02 21:14 ` Christoph Lameter
2007-05-02 21:27 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Lameter @ 2007-05-02 21:14 UTC (permalink / raw)
To: Pekka Enberg; +Cc: akpm, linux-kernel
On Wed, 2 May 2007, Pekka Enberg wrote:
> Christoph Lameter wrote:
> > Patch is already in mm. Could you download all the patches after that before
> > testing? There was quite a number.
>
> I am on 2.6.21-rc7-mm2. Me goes to wonder where Andrew's snapshots are...
Too much going on I think. I guess I saturated him with patches.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] slub: remove duplicate VM_BUG_ON
2007-05-02 21:14 ` Christoph Lameter
@ 2007-05-02 21:27 ` Andrew Morton
2007-05-02 21:42 ` Current SLUB Tree Christoph Lameter
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2007-05-02 21:27 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Pekka Enberg, linux-kernel
On Wed, 2 May 2007 14:14:39 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:
> On Wed, 2 May 2007, Pekka Enberg wrote:
>
> > Christoph Lameter wrote:
> > > Patch is already in mm. Could you download all the patches after that before
> > > testing? There was quite a number.
> >
> > I am on 2.6.21-rc7-mm2. Me goes to wonder where Andrew's snapshots are...
>
> Too much going on I think. I guess I saturated him with patches.
>
yes, I'm very much in "slow things down, do it more carefully" mode. I
have 350 patches sitting awaiting later consideration at present.
It's not so much that I'm personally swamped - it's more that I think we've
hit (exceeded) the rate at which we can feed stuff into the tree while
maintaining acceptable quality.
If others were to increase the amount of time they spend on testing,
reviewing and bugfixing it would help to level things out.
I should have got the 2.6.22-mm-merge-plans email out a week or two
earlier, I'm afraid. Things are looking somewhat messy.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-05-02 21:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-02 20:08 [PATCH] slub: remove duplicate VM_BUG_ON Pekka J Enberg
2007-05-02 20:12 ` Christoph Lameter
2007-05-02 20:21 ` Pekka Enberg
2007-05-02 21:14 ` Christoph Lameter
2007-05-02 21:27 ` Andrew Morton
2007-05-02 21:42 ` Current SLUB Tree Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox