From: Andrew Morton <akpm@linux-foundation.org>
To: Marc Pignat <marc.pignat@hevs.ch>
Cc: andrew@sanpeople.com, linux-kernel@vger.kernel.org,
dbrownell@users.sourceforge.net
Subject: Re: [PATCHv2] at91: fix enable/disable_irq_wake symmetry in pcmcia driver
Date: Thu, 10 May 2007 15:26:36 -0700 [thread overview]
Message-ID: <20070510152636.4adb3ef1.akpm@linux-foundation.org> (raw)
In-Reply-To: <200705101009.36302.marc.pignat@hevs.ch>
On Thu, 10 May 2007 10:09:35 +0200
Marc Pignat <marc.pignat@hevs.ch> wrote:
> from Marc Pignat <marc.pignat@hevs.ch>
>
> fix enable_irq_wake and disable_irq_wake symmetry in at91 pcmcia driver
>
> Signed-off-by: Marc Pignat <marc.pignat@hevs.ch>
> ---
> Please forget the [PATCH] at91: fix enable/disable_irq_wake symmetry in pcmcia driver,
> it doesn't compile... Here is the good patch!
>
> This patch applies to the 2.6.21.1 kernel.
>
> disable_irq_wake call must be symmetric with enable_irq_wake. This patch fix
> that problem for the at91_pcmia driver.
> It seems that this patch was forgotten when we've fixed irq_wake symmetry in
> all at91 related drivers.
> It was discussed in the "at91 drivers and [enable/disable]_irq_wake (wrong?)
> usage" thread on the linux-arm-kernel mailing list.
That's not a terribly useful changelog, sorry. I look at the patch and I
don't know what was wrong with the old code, nor how this new code improves
things.
"disable_irq_wake call must be symmetric with enable_irq_wake". hmm, OK,
I'll take your word for it.
Does the present code actually fail in some manner, or what?
next prev parent reply other threads:[~2007-05-10 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 8:09 [PATCHv2] at91: fix enable/disable_irq_wake symmetry in pcmcia driver Marc Pignat
2007-05-10 22:26 ` Andrew Morton [this message]
2007-05-11 6:01 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510152636.4adb3ef1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrew@sanpeople.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.pignat@hevs.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox