From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Marc Pignat <marc.pignat@hevs.ch>,
andrew@sanpeople.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] at91: fix enable/disable_irq_wake symmetry in pcmcia driver
Date: Thu, 10 May 2007 23:01:56 -0700 [thread overview]
Message-ID: <200705102301.56964.david-b@pacbell.net> (raw)
In-Reply-To: <20070510152636.4adb3ef1.akpm@linux-foundation.org>
On Thursday 10 May 2007, Andrew Morton wrote:
> "disable_irq_wake call must be symmetric with enable_irq_wake". hmm, OK,
> I'll take your word for it.
In the same way that enable_irq() and disable_irq() must be matched,
and for the same reasons: when the IRQ is shared between drivers,
they can't all treat enable/disable status as boolean. Those calls
mask refcountig.
> Does the present code actually fail in some manner, or what?
Yes ... runtime warnings flagging various misbehaviors associated
with refcount mismatches.
- Dave
prev parent reply other threads:[~2007-05-11 6:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 8:09 [PATCHv2] at91: fix enable/disable_irq_wake symmetry in pcmcia driver Marc Pignat
2007-05-10 22:26 ` Andrew Morton
2007-05-11 6:01 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705102301.56964.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=andrew@sanpeople.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.pignat@hevs.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox