2.6.22-rc2 built on ppc (3)

2.6.22-rc2 built on ppc (3)

[Elimar Riesebieter]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

Hi,

FYI, building the kernel with
gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7)
on my powerbook (PPC) gives:

...
fs/partitions/check.c: In function 'add_partition':
fs/partitions/check.c:392: warning: ignoring return value of 'kobject_add', declared with attribute warn_unused_result
fs/partitions/check.c:395: warning: ignoring return value of 'sysfs_create_link', declared with attribute warn_unused_result
fs/partitions/check.c:403: warning: ignoring return value of 'sysfs_create_file', declared with attribute warn_unused_result
...

If more info is needed, please contact me via PM, as I am not
subscribed.

Thanks for your patience
Elimar

-- 
  Never make anything simple and efficient when a way 
  can be found to make it complex and wonderful ;-)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.22-rc2 built on ppc (3)

[WANG Cong]

On Sun, May 20, 2007 at 01:11:13PM +0200, Elimar Riesebieter wrote:
>Hi,
>
>FYI, building the kernel with
>gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7)
>on my powerbook (PPC) gives:
>
>...
>fs/partitions/check.c: In function 'add_partition':
>fs/partitions/check.c:392: warning: ignoring return value of 'kobject_add', declared with attribute warn_unused_result
>fs/partitions/check.c:395: warning: ignoring return value of 'sysfs_create_link', declared with attribute warn_unused_result
>fs/partitions/check.c:403: warning: ignoring return value of 'sysfs_create_file', declared with attribute warn_unused_result
>...
>
>If more info is needed, please contact me via PM, as I am not
>subscribed.
>
>Thanks for your patience
>Elimar
>

I don't know why these warnings are still in kernel. We have fixed them yet. Could you please check and try this patch?

http://marc.info/?l=linux-mm-commits&m=117624330000536&w=2

CC: Andrew Morton <akpm@linux-foundation.org>
CC: Cornelia Huck <cornelia.huck@de.ibm.com>

Regards!

WANG Cong

Re: 2.6.22-rc2 built on ppc (3)

[Elimar Riesebieter]

On Sun, 20 May 2007 the mental interface of
WANG Cong told:

> On Sun, May 20, 2007 at 01:11:13PM +0200, Elimar Riesebieter wrote:
> >Hi,
> >
> >FYI, building the kernel with
> >gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7)
> >on my powerbook (PPC) gives:
> >
> >...
> >fs/partitions/check.c: In function 'add_partition':
> >fs/partitions/check.c:392: warning: ignoring return value of 'kobject_add', declared with attribute warn_unused_result
> >fs/partitions/check.c:395: warning: ignoring return value of 'sysfs_create_link', declared with attribute warn_unused_result
> >fs/partitions/check.c:403: warning: ignoring return value of 'sysfs_create_file', declared with attribute warn_unused_result
> >...
> >
> >If more info is needed, please contact me via PM, as I am not
> >subscribed.
> >
> >Thanks for your patience
> >Elimar
> >
> 
> I don't know why these warnings are still in kernel. We have fixed them yet. Could you please check and try this patch?
> 
> http://marc.info/?l=linux-mm-commits&m=117624330000536&w=2

  CC      fs/partitions/check.o
fs/partitions/check.c: In function 'add_partition':
fs/partitions/check.c:398: error: 'struct kset' has no member named 'kset'
make[2]: *** [fs/partitions/check.o] Error 1
^make[1]: *** [fs/partitions] Error 2

Elimar

-- 
  Excellent day for drinking heavily. 
  Spike the office water cooler;-)

Re: 2.6.22-rc2 built on ppc (3)

[WANG Cong]

On Sun, May 20, 2007 at 05:49:06PM +0200, Elimar Riesebieter wrote:
>On Sun, 20 May 2007 the mental interface of
>WANG Cong told:
>
>> On Sun, May 20, 2007 at 01:11:13PM +0200, Elimar Riesebieter wrote:
>> >Hi,
>> >
>> >FYI, building the kernel with
>> >gcc (GCC) 4.1.3 20070514 (prerelease) (Debian 4.1.2-7)
>> >on my powerbook (PPC) gives:
>> >
>> >...
>> >fs/partitions/check.c: In function 'add_partition':
>> >fs/partitions/check.c:392: warning: ignoring return value of 'kobject_add', declared with attribute warn_unused_result
>> >fs/partitions/check.c:395: warning: ignoring return value of 'sysfs_create_link', declared with attribute warn_unused_result
>> >fs/partitions/check.c:403: warning: ignoring return value of 'sysfs_create_file', declared with attribute warn_unused_result
>> >...
>> >
>> >If more info is needed, please contact me via PM, as I am not
>> >subscribed.
>> >
>> >Thanks for your patience
>> >Elimar
>> >
>> 
>> I don't know why these warnings are still in kernel. We have fixed them yet. Could you please check and try this patch?
>> 
>> http://marc.info/?l=linux-mm-commits&m=117624330000536&w=2
>
>  CC      fs/partitions/check.o
>fs/partitions/check.c: In function 'add_partition':
>fs/partitions/check.c:398: error: 'struct kset' has no member named 'kset'
>make[2]: *** [fs/partitions/check.o] Error 1
>^make[1]: *** [fs/partitions] Error 2
>
>Elimar
>

Oh, bad. I think something about struct kset has changed since we made this patch. Thanks for your try.
And could you pleae try this?

-	if (sysfs_create_link(&p->kobj, &block_subsys.kset.kobj, "subsystem"))
+	if (sysfs_create_link(&p->kobj, &block_subsys.kobj, "subsystem"))

If that cann't help you, please ask Andrew for the corresponding patch, I believe it is still in Andrew's tree. Thanks again!

Regards!