Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > This patch is on top of the "Freezer: Avoid freezing kernel threads prematurely"
> > patch that I posted yestarday, available at http://lkml.org/lkml/2007/5/25/199
> > (updated version that applies cleanly on top of 2.6.22-rc3, is available at
> > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc3/patches/07-freezer-avoid-freezing-kernel-threads-prematurely.patch).
> > It has been tested on a couple of machines and doesn't seem to break anything.
> > 
> > [As you can see there are quite a lot of files affected, so I didn't add all
> > maintainers of them to the CC list.  In fact, I'm not sure how to handle
> > notifying them of the change, so please advise.]
> 
> Does the lack of comments mean that everyone on the CC list agrees with this
> approach? ;-)
> 
> In the meantime, it turns out that this patch fixes the hibernation/suspend
> problem with cryptd discussed in the thread at
> http://lkml.org/lkml/2007/5/26/24 .
> 
> The problem is that cryptd doesn't call try_to_freeze() and doesn't set
> PF_NOFREEZE for itself, so the freezer cannot handle it properly.  In principle
> we can add either try_to_freeze() or the setting of PF_NOFREEZE to it, but if
> the approach in the $subject patch is acceptable, we'll need to remove that
> soon.  So, what should we do?

I'd add PF_NONFREEZE. Changing the defaults in freezer is obviously
not 2.6.22 material.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html