public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Gautham R Shenoy <ego@in.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Nigel Cunningham <nigel@nigel.suspend2.net>,
	Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default
Date: Tue, 29 May 2007 23:55:14 +0200	[thread overview]
Message-ID: <200705292355.15563.rjw@sisk.pl> (raw)
In-Reply-To: <20070529124816.GI23046@elf.ucw.cz>

On Tuesday, 29 May 2007 14:48, Pavel Machek wrote:
> Hi!
> 
> > > Well.. it can write anywhere it wants (filesystem or not) as long as
> > > the system is not going to be confused after resume by its caches not
> > > matching on-disk state. I'd prefer it not to write anywhere at all.
> > 
> > OK
> > 
> > Please have a look at the current version of the patch (appended).
> > 
> > I have followed the Nigel's suggestion not to change the current behavior
> > in this patch (I'll add a couple of patches removing the freezability from
> > some kernel threads), with one exception: I couldn't figure out any reason
> > to have try_to_freeze() called in net/sunrpc/svcsock.c:svc_recv() .
> 
> It probably broke suspend at some point... leave it there. Processes
> can stay in D period, waiting for NFS server to come back.
> 
> and yes, we want nfs threads frozen, too (and anything that talks to
> network). Speaking to nfs servers while we are suspending the machine
> is not nice, and if that continues after snapshot, we'll act as a very
> confused machine to the outside...

OK, I've added set_freezable() to the NFS-related threads.

[Updated patch is in the reply to Nigel.]

Greetings,
Rafael

  reply	other threads:[~2007-05-29 22:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26 22:12 [RFC][PATCH][EXPERIMENTAL] Make kernel threads nonfreezable by default Rafael J. Wysocki
2007-05-28  8:09 ` Rafael J. Wysocki
2007-05-28 10:30   ` Pavel Machek
2007-05-28 18:11     ` Rafael J. Wysocki
2007-05-28  9:46 ` Nigel Cunningham
2007-05-28 18:17   ` Rafael J. Wysocki
2007-05-28 21:26     ` Nigel Cunningham
2007-05-28 22:51       ` Rafael J. Wysocki
2007-05-28 22:54         ` Nigel Cunningham
2007-05-30 22:01       ` [RFC][PATCH -mm] Freezer: " Rafael J. Wysocki
2007-05-28 10:33 ` [RFC][PATCH][EXPERIMENTAL] " Pavel Machek
2007-05-28 18:11   ` Rafael J. Wysocki
2007-05-29 11:31     ` Pavel Machek
2007-05-29 12:15       ` Rafael J. Wysocki
2007-05-29 12:48         ` Pavel Machek
2007-05-29 21:55           ` Rafael J. Wysocki [this message]
2007-05-29 12:59         ` Nigel Cunningham
2007-05-29 22:13           ` Rafael J. Wysocki
2007-05-29 22:15             ` Nigel Cunningham
2007-05-29 15:01         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705292355.15563.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nigel@nigel.suspend2.net \
    --cc=oleg@tv-sign.ru \
    --cc=pavel@ucw.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox