public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [RFC] tablet buttons driver for fujitsu siemens laptops
Date: Fri, 1 Jun 2007 18:30:54 -0700	[thread overview]
Message-ID: <20070601183054.44c09935@freepuppy> (raw)
In-Reply-To: <200706020259.34033.khnz@gmx.de>

On Sat, 2 Jun 2007 02:59:33 +0200
Robert Gerlach <khnz@gmx.de> wrote:

> Hi,
> 
> I have written a driver for the tablet buttons of (some?) Fujitsu Siemens 
> tablet notebook. Can someone please review this (I'm a newbie here).
> 
> Other questions, where should the modification button (fn) handled (kernel- or 
> userspace)? This button should work like stickykey's in gnome (for 
> one-finger-use). Currently, I have a small userspace daemon for this.
> 
> Some models doesn't have a brightness up and down, only a backlight on and off 
> button. What event should reported there.
> 
> Thanks,
> Robert
> 
> 
> #ifdef DEBUG
> #  define debug(m, a...)	printk( KERN_DEBUG   MODULENAME ": " m "\n", ##a)
> #else
> #  define debug(m, a...)	do {} while(0)
> #endif
> 
> #define info(m, a...)	printk( KERN_INFO    MODULENAME ": " m "\n", ##a)
> #define warn(m, a...)	printk( KERN_WARNING MODULENAME ": " m "\n", ##a)
> #define error(m, a...)	printk( KERN_ERR     MODULENAME ": " m "\n", ##a)
>
>

Please don't reinvent
	pr_debug
	pr_info
	pr_warn,...


-- 
Stephen Hemminger <shemminger@linux-foundation.org>


  reply	other threads:[~2007-06-02  1:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02  0:59 [RFC] tablet buttons driver for fujitsu siemens laptops Robert Gerlach
2007-06-02  1:30 ` Stephen Hemminger [this message]
2007-06-06  8:45   ` Robert Gerlach
2007-06-06 16:03     ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2007-08-01  8:51 Evgeny Stambulchik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070601183054.44c09935@freepuppy \
    --to=shemminger@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox