From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Robert Gerlach <khnz@khnz.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] tablet buttons driver for fujitsu siemens laptops
Date: Wed, 6 Jun 2007 09:03:59 -0700 [thread overview]
Message-ID: <20070606090359.5550a813@freepuppy> (raw)
In-Reply-To: <200706061045.42915.khnz@khnz.de>
On Wed, 6 Jun 2007 10:45:42 +0200
Robert Gerlach <khnz@khnz.de> wrote:
> On Saturday 02 June 2007 03:30:54 Stephen Hemminger wrote:
> > On Sat, 2 Jun 2007 02:59:33 +0200
> > > #ifdef DEBUG
> > > # define debug(m, a...) printk( KERN_DEBUG MODULENAME ": " m "\n",
> > > ##a) #else
> > > # define debug(m, a...) do {} while(0)
> > > #endif
> > >
> > > #define info(m, a...) printk( KERN_INFO MODULENAME ": " m "\n", ##a)
> > > #define warn(m, a...) printk( KERN_WARNING MODULENAME ": " m "\n", ##a)
> > > #define error(m, a...) printk( KERN_ERR MODULENAME ": " m "\n", ##a)
> >
> > Please don't reinvent
> > pr_debug
> > pr_info
>
> Changed.
>
> > pr_warn,...
>
> There is no pr_warn. Is it ok to define it like pr_err in spider_net.c or is
> there a better way?
>
The best would be to use the following if you have a device
dev_err, dev_info, dev_warn, dev_notice
Also, you need to format this a proper patch with config, makefile, etc.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-06-06 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-02 0:59 [RFC] tablet buttons driver for fujitsu siemens laptops Robert Gerlach
2007-06-02 1:30 ` Stephen Hemminger
2007-06-06 8:45 ` Robert Gerlach
2007-06-06 16:03 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-01 8:51 Evgeny Stambulchik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070606090359.5550a813@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=khnz@khnz.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox