From: Andi Kleen <andi@firstfloor.org>
To: Christoph Hellwig <hch@infradead.org>,
Andi Kleen <andi@firstfloor.org>, Rik van Riel <riel@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
andrew.vasquez@qlogic.com
Subject: Re: [PATCH] quiet down swiotlb warnings
Date: Fri, 1 Jun 2007 21:37:03 +0200 [thread overview]
Message-ID: <20070601193703.GI7217@one.firstfloor.org> (raw)
In-Reply-To: <20070601181225.GA16460@infradead.org>
On Fri, Jun 01, 2007 at 07:12:25PM +0100, Christoph Hellwig wrote:
> On Fri, Jun 01, 2007 at 09:01:45PM +0200, Andi Kleen wrote:
> > Bad idea imho. swiotlb mappings should always lead to printk by default
> > because it is pretty dangerous.
> >
> > One possible solution for this I could think of would be to define a
> > new pci_map_sg_couldfail() or similar that doesn't warn and use a weak
> > fallback just calling pci_map_sg on other IOMMU implementations.
>
> pci_map_sg is defined to be failing when running out of ressources, which
> is perfectly fine. We don't printk on kmalloc failures either (actually
Actually we do as you point out.
> in some cases which is highly annoying and leads people to stick a
> __GFP_NOWARN into various places)
An pci_map_sg failing typically leads to an IO error and we've
always printk'ed those. Otherwise people will wonder why they
get EIO.
-Andi
next prev parent reply other threads:[~2007-06-01 19:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 17:30 [PATCH] quiet down swiotlb warnings Rik van Riel
2007-06-01 19:01 ` Andi Kleen
2007-06-01 18:12 ` Christoph Hellwig
2007-06-01 18:18 ` Rik van Riel
2007-06-01 19:37 ` Andi Kleen [this message]
2007-06-01 19:38 ` Rik van Riel
2007-06-01 19:47 ` Andi Kleen
2007-06-01 20:00 ` Andrew Vasquez
2007-06-01 20:14 ` Andi Kleen
2007-06-01 20:20 ` Rik van Riel
2007-06-01 20:26 ` Andi Kleen
2007-06-02 15:21 ` Muli Ben-Yehuda
2007-06-02 16:47 ` Andi Kleen
2007-06-01 19:57 ` Christoph Hellwig
2007-06-01 18:16 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070601193703.GI7217@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=andrew.vasquez@qlogic.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox