[PATCH] Export usb_gadgetfs.h to userspace

[PATCH] Export usb_gadgetfs.h to userspace

[Haavard Skinnemoen]

The gadgetfs test program from http://www.linux-usb.org/gadget/
depends on it. I assume most other users of gadgetfs needs this header
too.

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index f317c27..b216ee3 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -152,6 +152,7 @@ header-y += tipc.h
 header-y += toshiba.h
 header-y += ultrasound.h
 header-y += un.h
+header-y += usb_gadgetfs.h
 header-y += utime.h
 header-y += video_decoder.h
 header-y += video_encoder.h
-- 
1.5.2.2

Re: [PATCH] Export usb_gadgetfs.h to userspace

[David Brownell]

On Monday 25 June 2007, Haavard Skinnemoen wrote:
> The gadgetfs test program from http://www.linux-usb.org/gadget/
> depends on it. I assume most other users of gadgetfs needs this header
> too.

There's already a patch in the 2.6.23 queue which moves this
to <linux/usb/gadgetfs.h> and exports it from there:

   http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6
	/gregkh-03-usb/usb-export-linux-usb_gadgetfs-as-linux-usb-gadgetfs.h.patch

(URL is manually line wrapped).

- Dave

Re: [PATCH] Export usb_gadgetfs.h to userspace

[Andrew Morton]

On Mon, 25 Jun 2007 11:29:39 +0200 Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:

> The gadgetfs test program from http://www.linux-usb.org/gadget/
> depends on it. I assume most other users of gadgetfs needs this header
> too.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> ---
>  include/linux/Kbuild |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index f317c27..b216ee3 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -152,6 +152,7 @@ header-y += tipc.h
>  header-y += toshiba.h
>  header-y += ultrasound.h
>  header-y += un.h
> +header-y += usb_gadgetfs.h
>  header-y += utime.h
>  header-y += video_decoder.h
>  header-y += video_encoder.h

`make headers_check' fails:

make[2]: *** No rule to make target `/usr/src/devel/include/linux/usb_gadgetfs.h', needed by `/usr/src/devel/usr/include/linux/usb_gadgetfs.h'.  Stop.

Re: [PATCH] Export usb_gadgetfs.h to userspace

[Haavard Skinnemoen]

On Wed, 27 Jun 2007 00:35:38 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> `make headers_check' fails:
> 
> make[2]: *** No rule to make target `/usr/src/devel/include/linux/usb_gadgetfs.h', needed by `/usr/src/devel/usr/include/linux/usb_gadgetfs.h'.  Stop.

It has already been moved to linux/usb/gadgetfs.h and properly exported
in -mm. Please just ignore this patch, it's redundant.

Haavard

Re: [PATCH] Export usb_gadgetfs.h to userspace

[David Woodhouse]

On Wed, 2007-06-27 at 00:35 -0700, Andrew Morton wrote:
> make[2]: *** No rule to make target
> `/usr/src/devel/include/linux/usb_gadgetfs.h', needed by
> `/usr/src/devel/usr/include/linux/usb_gadgetfs.h'.  Stop. 

i.e. "Cannot export file to ./usr/include/linux/ because it doesn't
exist in ./include/linux/ in the first place" -- for the reasons Håvard
pointed out.

-- 
dwmw2