From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Ingo Molnar <mingo@redhat.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Sattler <tsattler@gmx.de>
Subject: Re: [RFC/PATCH] debug workqueue deadlocks with lockdep
Date: Thu, 5 Jul 2007 10:43:23 +0200 [thread overview]
Message-ID: <20070705084323.GB2447@elte.hu> (raw)
In-Reply-To: <20070704125219.GA98@tv-sign.ru>
* Oleg Nesterov <oleg@tv-sign.ru> wrote:
> > > Isn't it better to call lock_release() with nested == 1 ?
> >
> > Not sure, Ingo?
>
> Ingo, could you also explain the meaning of "nested" parameter? Looks
> like it is just unneeded, lock_release_nested() does a quick check and
> use lock_release_non_nested() when hlock is not on top of stack.
hm, i forgot about that. We basically turned off all bad-nesting
warnings in lockdep due to false positives.
the workqueue dependencies should all nest perfectly so please just use
nested==1, even though it's a dummy right now. We might want to turn
unlock-nest checking back on in the future. Or we'll remove that
parameter altogether.
Ingo
prev parent reply other threads:[~2007-07-05 8:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 18:40 [RFC/PATCH] debug workqueue deadlocks with lockdep Johannes Berg
2007-06-28 16:33 ` Johannes Berg
2007-06-28 17:33 ` Johannes Berg
2007-06-30 8:05 ` Ingo Molnar
2007-06-30 11:46 ` Oleg Nesterov
2007-07-02 8:37 ` Johannes Berg
2007-07-02 13:03 ` Johannes Berg
2007-07-03 17:31 ` Oleg Nesterov
2007-07-03 19:42 ` Ingo Molnar
2007-07-04 11:49 ` Johannes Berg
2007-07-04 12:21 ` Ingo Molnar
2007-07-04 13:59 ` Johannes Berg
2007-07-04 12:25 ` Ingo Molnar
2007-07-04 12:52 ` Oleg Nesterov
2007-07-04 13:57 ` Johannes Berg
2007-07-05 8:43 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070705084323.GB2447@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@tv-sign.ru \
--cc=tsattler@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox