From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
nigel@suspend2.net,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
LKML <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Oliver Neukum <oliver@neukum.org>,
Paul Mackerras <paulus@samba.org>,
Miklos Szeredi <miklos@szeredi.hu>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC][PATCH -mm] PM: Do not sync filesystems from within the freezer
Date: Fri, 6 Jul 2007 09:02:53 +0200 [thread overview]
Message-ID: <200707060902.55090.rjw@sisk.pl> (raw)
In-Reply-To: <20070705220046.GC3881@elf.ucw.cz>
On Friday, 6 July 2007 00:00, Pavel Machek wrote:
> Hi!
>
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > The syncing of filesystems from within the freezer is generally not needed.
> > Change freeze_processes() so that it doesn't execute sys_sync() and make the
> > suspend and hibernation code path sync filesystems independently of the freezer.
>
> Yes, we can do that, but ... why?
I think that sync and the freezer are different things and shouldn't be mixed in
such a way as they are now.
> Does it actually fix FUSE?
It should prevent the freezer from deadlocking.
> Miklos claims sync is nop on FUSE...?
In that case there shouldn't be any deadlock, but a freezer failure. :-)
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
next prev parent reply other threads:[~2007-07-06 6:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 14:58 [RFC][PATCH -mm] PM: Do not sync from within the freezer during suspend to RAM Rafael J. Wysocki
2007-07-04 22:48 ` Nigel Cunningham
2007-07-04 22:49 ` Pavel Machek
2007-07-04 22:52 ` Nigel Cunningham
2007-07-05 11:28 ` Rafael J. Wysocki
2007-07-05 11:37 ` Nigel Cunningham
2007-07-05 20:31 ` [RFC][PATCH -mm] PM: Do not sync filesystems from within the freezer Rafael J. Wysocki
2007-07-05 22:00 ` Pavel Machek
2007-07-06 7:02 ` Rafael J. Wysocki [this message]
2007-07-06 7:07 ` Nigel Cunningham
2007-07-06 7:13 ` Miklos Szeredi
2007-07-06 7:19 ` Nigel Cunningham
2007-07-06 7:36 ` Miklos Szeredi
2007-07-07 11:48 ` possible solution for problem 2 (was Re: [RFC][PATCH -mm] PM: Do not sync filesystems from within the freezer) Pavel Machek
2007-07-06 8:59 ` [RFC][PATCH -mm] PM: Do not sync filesystems from within the freezer Benjamin Herrenschmidt
2007-07-06 9:05 ` Miklos Szeredi
2007-07-06 9:13 ` Nigel Cunningham
2007-07-06 9:31 ` Miklos Szeredi
2007-07-06 10:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707060902.55090.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=miklos@szeredi.hu \
--cc=mingo@elte.hu \
--cc=mjg59@srcf.ucam.org \
--cc=nigel@suspend2.net \
--cc=oliver@neukum.org \
--cc=paulus@samba.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox