can entire drivers/acorn subdirectory be removed?

can entire drivers/acorn subdirectory be removed?

[Robert P. J. Day]

  given that:

1) drivers/Makefile doesn't even have an entry for the acorn/
   subdirectory, and

2) the Makefile drivers/acorn/char/Makefile is incorrect anyway, since
   it contains:

    obj-$(CONFIG_L7200_KEYB)        += defkeymap-l7200.o keyb_l7200.o

   which refers to a non-existent source file keyb_l7200.c, and it's
based on a non-existent config variable on top of that.  it certainly
seems that that entire subdirectory can be tossed.

  and if that happens, then the config variables defined in
drivers/acorn/block/Kconfig:

  config BLK_DEV_FD1772
  config BLK_DEV_MFM
  config BLK_DEV_MFM_AUTODETECT

would also vanish, which suggests that any references to *them* could
also be deleted:

$ grep -r BLK_DEV_FD1772 *
arch/arm26/defconfig:# CONFIG_BLK_DEV_FD1772 is not set
arch/arm26/machine/dma.c:#if defined(CONFIG_BLK_DEV_FD1772) || defined(CONFIG_BLK_DEV_FD1772_MODULE)
arch/arm26/machine/dma.c:#if defined(CONFIG_BLK_DEV_FD1772) || defined(CONFIG_BLK_DEV_FD1772_MODULE)
...

  anyway, you get the idea.  thoughts?

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: can entire drivers/acorn subdirectory be removed?

[Dr. David Alan Gilbert]

* Robert P. J. Day (rpjday@mindspring.com) wrote:

>   and if that happens, then the config variables defined in
> drivers/acorn/block/Kconfig:
> 
>   config BLK_DEV_FD1772
>   config BLK_DEV_MFM
>   config BLK_DEV_MFM_AUTODETECT
> 
> would also vanish, which suggests that any references to *them* could
> also be deleted:

Ah those are blasts from the past; I've got to wonder how many
MFM drives that still work are out there.

I should take the 5.25" FH 64MB drive I tested that on to the tip
sometime.

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    | Running GNU/Linux on Alpha,68K| Happy  \ 
\ gro.gilbert @ treblig.org | MIPS,x86,ARM,SPARC,PPC & HPPA | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: can entire drivers/acorn subdirectory be removed?

[Robert P. J. Day]

On Fri, 6 Jul 2007, Dr. David Alan Gilbert wrote:

> * Robert P. J. Day (rpjday@mindspring.com) wrote:
>
> >   and if that happens, then the config variables defined in
> > drivers/acorn/block/Kconfig:
> >
> >   config BLK_DEV_FD1772
> >   config BLK_DEV_MFM
> >   config BLK_DEV_MFM_AUTODETECT
> >
> > would also vanish, which suggests that any references to *them* could
> > also be deleted:
>
> Ah those are blasts from the past; I've got to wonder how many MFM
> drives that still work are out there.

the question remains -- is there any value to keeping the acorn stuff
given that the Kconfig variables to select that code aren't defined
anywhere?

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: can entire drivers/acorn subdirectory be removed?

[Satyam Sharma]

On 7/10/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
> On Fri, 6 Jul 2007, Dr. David Alan Gilbert wrote:
>
> > * Robert P. J. Day (rpjday@mindspring.com) wrote:
> >
> > >   and if that happens, then the config variables defined in
> > > drivers/acorn/block/Kconfig:
> > >
> > >   config BLK_DEV_FD1772
> > >   config BLK_DEV_MFM
> > >   config BLK_DEV_MFM_AUTODETECT
> > >
> > > would also vanish, which suggests that any references to *them* could
> > > also be deleted:
> >
> > Ah those are blasts from the past; I've got to wonder how many MFM
> > drives that still work are out there.
>
> the question remains -- is there any value to keeping the acorn stuff
> given that the Kconfig variables to select that code aren't defined
> anywhere?

Would be best to just send out a patch getting rid of all that cruft.
If anybody (maintainer or otherwise) disagrees, we'll know then.

Satyam