The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>, Chris Wright <chrisw@sous-sol.org>
Subject: [patch-mm 22/33] x86_64: Remove APIC_DIVISOR
Date: Sun, 15 Jul 2007 16:11:04 -0000	[thread overview]
Message-ID: <20070715155541.651124309@inhelltoy.tec.linutronix.de> (raw)
In-Reply-To: 20070715155510.341941668@inhelltoy.tec.linutronix.de

[-- Attachment #1: x86_64-apic-calibration-remove-divisor.patch --]
[-- Type: text/plain, Size: 1792 bytes --]

APIC_DIVISOR is rather useless. It makes the calibration result more
accurate in the first place, but we discard this later when we write
the value to the APIC timer by dividing the calibration value by
APIC_DIVISOR.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

---
 arch/x86_64/kernel/apic.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Index: linux-2.6.22-rc6-mm/arch/x86_64/kernel/apic.c
===================================================================
--- linux-2.6.22-rc6-mm.orig/arch/x86_64/kernel/apic.c	2007-07-15 17:40:59.000000000 +0200
+++ linux-2.6.22-rc6-mm/arch/x86_64/kernel/apic.c	2007-07-15 17:48:57.000000000 +0200
@@ -760,8 +760,6 @@ void __init init_apic_mappings(void)
  * P5 APIC double write bug.
  */
 
-#define APIC_DIVISOR 16
-
 static void __setup_APIC_LVTT(unsigned int clocks, int oneshot, int irqen)
 {
 	unsigned int lvtt_value, tmp_value;
@@ -783,7 +781,7 @@ static void __setup_APIC_LVTT(unsigned i
 				| APIC_TDR_DIV_16);
 
 	if (!oneshot)
-		apic_write(APIC_TMICT, clocks/APIC_DIVISOR);
+		apic_write(APIC_TMICT, clocks);
 }
 
 static void setup_APIC_timer(unsigned int clocks)
@@ -836,7 +834,7 @@ static void __init calibrate_APIC_clock(
 	 *
 	 * No interrupt enable !
 	 */
-	__setup_APIC_LVTT(4000000000, 0, 0);
+	__setup_APIC_LVTT(250000000, 0, 0);
 
 	apic_start = apic_read(APIC_TMCCT);
 #ifdef CONFIG_X86_PM_TIMER
@@ -863,7 +861,7 @@ static void __init calibrate_APIC_clock(
 	printk(KERN_INFO "Detected %d.%03d MHz APIC timer.\n",
 		result / 1000 / 1000, result / 1000 % 1000);
 
-	calibration_result = result * APIC_DIVISOR / HZ;
+	calibration_result = result / HZ;
 }
 
 void __init setup_boot_APIC_clock (void)

-- 


  parent reply	other threads:[~2007-07-15 16:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-15 16:10 [patch-mm 00/33] x86_64 clock events conversion - V5 Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 01/33] clockevents: Remove unused inline function Thomas Gleixner
2007-07-17 12:33   ` Andi Kleen
2007-07-17 14:58     ` Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 02/33] clockevents: Allow build w/o run-tine usage for migration purposes Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 03/33] i386: remove pit_interrupt_hook Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 04/33] X86_64: hpet tsc calibration fix broken smi detection logic Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 05/33] x86_64: Untangle asm/hpet.h from asm/timex.h Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 06/33] x86_64: use generic cmos update Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 07/33] x86_64: Use generic xtime init Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 08/33] x86_64: Remove dead code and other janitor work in tsc.c Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 09/33] x86_64: Fix APIC typo Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 10/33] x86_64: fiuxp pt_reqs leftovers Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 11/33] x86_64: share hpet.h with i386 Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 12/33] x86_64: apic.c coding style janitor work Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 13/33] x86_64: time.c white space wreckage cleanup Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 14/33] x86_64: Consolidate tsc calibration Thomas Gleixner
2007-07-17 12:51   ` Andi Kleen
2007-07-17 15:00     ` Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 15/33] i386: prepare sharing the hpet code with x86_64 Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 16/33] i386: hpet add x8664 bits Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 17/33] i386: prepare sharing the PIT code Thomas Gleixner
2007-07-15 16:10 ` [patch-mm 18/33] x86_64: use shared i8253.h Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 19/33] x86_64: prepare apic code for clock events Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 20/33] x86_64: remove pit synchronization Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 21/33] x86_64: Move apic calibration code around Thomas Gleixner
2007-07-15 16:11 ` Thomas Gleixner [this message]
2007-07-15 16:11 ` [patch-mm 23/33] x86_64: apic change setup_APIC_timer calling convention Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 24/33] x86_64: remove nested irq disables Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 25/33] x86_64: prepare idle loop for dynamic ticks Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 26/33] x86_64: apic add clock event functions Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 27/33] x86_64: convert to clock events Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 28/33] x86_64: remove now unused code Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 29/33] x86_64: cleanup apic.c after clock events switch Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 30/33] jiffies: remove unused macros Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 31/33] ACPI: remove the now unused ifdef code Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 32/33] i386: Remove the useless #ifdef in i8253.h Thomas Gleixner
2007-07-15 16:11 ` [patch-mm 33/33] i386/x8664: cleanup the shared hpet code Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070715155541.651124309@inhelltoy.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox