From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: randy.dunlap@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][resend] Remove spec doc links in hpet header files
Date: Thu, 19 Jul 2007 18:33:14 -0700 [thread overview]
Message-ID: <20070719183314.2d7d2331.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070720084510.GA1779@darkstar.te-china.tietoenator.com>
On Fri, 20 Jul 2007 08:45:10 +0000
Dave Young <hidave.darkstar@gmail.com> wrote:
> Hi,
> The links are broken, and already exist in Documentation/hpet.txt, so
> remove them for header files.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> ---
> include/asm-i386/hpet.h | 6 ------
> include/asm-x86_64/hpet.h | 6 ------
> 2 files changed, 12 deletions(-)
>
> diff -pur linux/include/asm-i386/hpet.h linux.new/include/asm-i386/hpet.h
> --- linux/include/asm-i386/hpet.h 2007-07-11 11:15:42.000000000 +0000
> +++ linux.new/include/asm-i386/hpet.h 2007-07-11 11:16:51.000000000 +0000
> @@ -28,12 +28,6 @@
>
> #include <linux/timex.h>
>
> -/*
> - * Documentation on HPET can be found at:
> - * http://www.intel.com/ial/home/sp/pcmmspec.htm
> - * ftp://download.intel.com/ial/home/sp/mmts098.pdf
> - */
> -
> #define HPET_MMAP_SIZE 1024
>
> #define HPET_ID 0x000
> diff -pur linux/include/asm-x86_64/hpet.h linux.new/include/asm-x86_64/hpet.h
> --- linux/include/asm-x86_64/hpet.h 2007-07-11 11:16:07.000000000 +0000
> +++ linux.new/include/asm-x86_64/hpet.h 2007-07-11 11:17:03.000000000 +0000
> @@ -1,12 +1,6 @@
> #ifndef _ASM_X8664_HPET_H
> #define _ASM_X8664_HPET_H 1
>
> -/*
> - * Documentation on HPET can be found at:
> - * http://www.intel.com/ial/home/sp/pcmmspec.htm
> - * ftp://download.intel.com/ial/home/sp/mmts098.pdf
> - */
> -
> #define HPET_MMAP_SIZE 1024
>
> #define HPET_ID 0x000
It only half-applies here because 100 monkeys are tromping all over the
hpet code.
But I'm inclined to duck it anyway: having the documentation references in
the soruce doesn't hurt, and nobody looks in Documentation/.
next prev parent reply other threads:[~2007-07-20 1:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 8:45 [PATCH][resend] Remove spec doc links in hpet header files Dave Young
2007-07-20 1:33 ` Andrew Morton [this message]
2007-07-20 1:37 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719183314.2d7d2331.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox