* Re: [PATCH][resend] Remove spec doc links in hpet header files
2007-07-20 8:45 [PATCH][resend] Remove spec doc links in hpet header files Dave Young
@ 2007-07-20 1:33 ` Andrew Morton
2007-07-20 1:37 ` Dave Young
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-07-20 1:33 UTC (permalink / raw)
To: Dave Young; +Cc: randy.dunlap, linux-kernel
On Fri, 20 Jul 2007 08:45:10 +0000
Dave Young <hidave.darkstar@gmail.com> wrote:
> Hi,
> The links are broken, and already exist in Documentation/hpet.txt, so
> remove them for header files.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> ---
> include/asm-i386/hpet.h | 6 ------
> include/asm-x86_64/hpet.h | 6 ------
> 2 files changed, 12 deletions(-)
>
> diff -pur linux/include/asm-i386/hpet.h linux.new/include/asm-i386/hpet.h
> --- linux/include/asm-i386/hpet.h 2007-07-11 11:15:42.000000000 +0000
> +++ linux.new/include/asm-i386/hpet.h 2007-07-11 11:16:51.000000000 +0000
> @@ -28,12 +28,6 @@
>
> #include <linux/timex.h>
>
> -/*
> - * Documentation on HPET can be found at:
> - * http://www.intel.com/ial/home/sp/pcmmspec.htm
> - * ftp://download.intel.com/ial/home/sp/mmts098.pdf
> - */
> -
> #define HPET_MMAP_SIZE 1024
>
> #define HPET_ID 0x000
> diff -pur linux/include/asm-x86_64/hpet.h linux.new/include/asm-x86_64/hpet.h
> --- linux/include/asm-x86_64/hpet.h 2007-07-11 11:16:07.000000000 +0000
> +++ linux.new/include/asm-x86_64/hpet.h 2007-07-11 11:17:03.000000000 +0000
> @@ -1,12 +1,6 @@
> #ifndef _ASM_X8664_HPET_H
> #define _ASM_X8664_HPET_H 1
>
> -/*
> - * Documentation on HPET can be found at:
> - * http://www.intel.com/ial/home/sp/pcmmspec.htm
> - * ftp://download.intel.com/ial/home/sp/mmts098.pdf
> - */
> -
> #define HPET_MMAP_SIZE 1024
>
> #define HPET_ID 0x000
It only half-applies here because 100 monkeys are tromping all over the
hpet code.
But I'm inclined to duck it anyway: having the documentation references in
the soruce doesn't hurt, and nobody looks in Documentation/.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][resend] Remove spec doc links in hpet header files
2007-07-20 1:33 ` Andrew Morton
@ 2007-07-20 1:37 ` Dave Young
0 siblings, 0 replies; 3+ messages in thread
From: Dave Young @ 2007-07-20 1:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: randy.dunlap, linux-kernel
>On 7/20/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 20 Jul 2007 08:45:10 +0000
> Dave Young <hidave.darkstar@gmail.com> wrote:
>
> > Hi,
> > The links are broken, and already exist in Documentation/hpet.txt, so
> > remove them for header files.
> >
> > Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> > Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > ---
> > include/asm-i386/hpet.h | 6 ------
> > include/asm-x86_64/hpet.h | 6 ------
> > 2 files changed, 12 deletions(-)
> >
> > diff -pur linux/include/asm-i386/hpet.h linux.new/include/asm-i386/hpet.h
> > --- linux/include/asm-i386/hpet.h 2007-07-11 11:15:42.000000000 +0000
> > +++ linux.new/include/asm-i386/hpet.h 2007-07-11 11:16:51.000000000 +0000
> > @@ -28,12 +28,6 @@
> >
> > #include <linux/timex.h>
> >
> > -/*
> > - * Documentation on HPET can be found at:
> > - * http://www.intel.com/ial/home/sp/pcmmspec.htm
> > - * ftp://download.intel.com/ial/home/sp/mmts098.pdf
> > - */
> > -
> > #define HPET_MMAP_SIZE 1024
> >
> > #define HPET_ID 0x000
> > diff -pur linux/include/asm-x86_64/hpet.h linux.new/include/asm-x86_64/hpet.h
> > --- linux/include/asm-x86_64/hpet.h 2007-07-11 11:16:07.000000000 +0000
> > +++ linux.new/include/asm-x86_64/hpet.h 2007-07-11 11:17:03.000000000 +0000
> > @@ -1,12 +1,6 @@
> > #ifndef _ASM_X8664_HPET_H
> > #define _ASM_X8664_HPET_H 1
> >
> > -/*
> > - * Documentation on HPET can be found at:
> > - * http://www.intel.com/ial/home/sp/pcmmspec.htm
> > - * ftp://download.intel.com/ial/home/sp/mmts098.pdf
> > - */
> > -
> > #define HPET_MMAP_SIZE 1024
> >
> > #define HPET_ID 0x000
>
> It only half-applies here because 100 monkeys are tromping all over the
> hpet code.
>
> But I'm inclined to duck it anyway: having the documentation references in
> the soruce doesn't hurt, and nobody looks in Documentation/.
>
Hi,
But at least the web urls are broken, please update to below address:
<http://www.intel.com/technology/architecture/hpetspec.htm>.
Regards
dave
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH][resend] Remove spec doc links in hpet header files
@ 2007-07-20 8:45 Dave Young
2007-07-20 1:33 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Dave Young @ 2007-07-20 8:45 UTC (permalink / raw)
To: akpm; +Cc: randy.dunlap, linux-kernel
Hi,
The links are broken, and already exist in Documentation/hpet.txt, so
remove them for header files.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
---
include/asm-i386/hpet.h | 6 ------
include/asm-x86_64/hpet.h | 6 ------
2 files changed, 12 deletions(-)
diff -pur linux/include/asm-i386/hpet.h linux.new/include/asm-i386/hpet.h
--- linux/include/asm-i386/hpet.h 2007-07-11 11:15:42.000000000 +0000
+++ linux.new/include/asm-i386/hpet.h 2007-07-11 11:16:51.000000000 +0000
@@ -28,12 +28,6 @@
#include <linux/timex.h>
-/*
- * Documentation on HPET can be found at:
- * http://www.intel.com/ial/home/sp/pcmmspec.htm
- * ftp://download.intel.com/ial/home/sp/mmts098.pdf
- */
-
#define HPET_MMAP_SIZE 1024
#define HPET_ID 0x000
diff -pur linux/include/asm-x86_64/hpet.h linux.new/include/asm-x86_64/hpet.h
--- linux/include/asm-x86_64/hpet.h 2007-07-11 11:16:07.000000000 +0000
+++ linux.new/include/asm-x86_64/hpet.h 2007-07-11 11:17:03.000000000 +0000
@@ -1,12 +1,6 @@
#ifndef _ASM_X8664_HPET_H
#define _ASM_X8664_HPET_H 1
-/*
- * Documentation on HPET can be found at:
- * http://www.intel.com/ial/home/sp/pcmmspec.htm
- * ftp://download.intel.com/ial/home/sp/mmts098.pdf
- */
-
#define HPET_MMAP_SIZE 1024
#define HPET_ID 0x000
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-20 1:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-20 8:45 [PATCH][resend] Remove spec doc links in hpet header files Dave Young
2007-07-20 1:33 ` Andrew Morton
2007-07-20 1:37 ` Dave Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox