From: Andrew Morton <akpm@linux-foundation.org>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: rpurdie@rpsys.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t
Date: Mon, 10 Sep 2007 22:04:23 -0700 [thread overview]
Message-ID: <20070910220423.43e0a4d9.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070904162345.30e82bc8.yoichi_yuasa@tripeaks.co.jp>
On Tue, 4 Sep 2007 16:23:45 +0900 Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
>
> This patch has added #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t.
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
> diff -pruN -X generic/Documentation/dontdiff generic-orig/include/linux/leds.h generic/include/linux/leds.h
> --- generic-orig/include/linux/leds.h 2007-09-04 14:59:51.334686250 +0900
> +++ generic/include/linux/leds.h 2007-09-04 14:56:10.676896000 +0900
> @@ -13,6 +13,7 @@
> #define __LINUX_LEDS_H_INCLUDED
>
> #include <linux/list.h>
> +#include <linux/spinlock_types.h>
>
> struct device;
> /*
I think spinlock_types.h is more an internal implementation detail, and
that leds.h should be including plain old <linux/spinlock.h>. Does that
change also fix whatever build error you were seeing?
next prev parent reply other threads:[~2007-09-11 5:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 7:23 [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t Yoichi Yuasa
2007-09-11 5:04 ` Andrew Morton [this message]
2007-09-11 8:48 ` Yoichi Yuasa
2007-09-11 21:30 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070910220423.43e0a4d9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox