* [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t
@ 2007-09-04 7:23 Yoichi Yuasa
2007-09-11 5:04 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Yoichi Yuasa @ 2007-09-04 7:23 UTC (permalink / raw)
To: rpurdie; +Cc: yoichi_yuasa, Andrew Morton, Linux Kernel Mailing List
This patch has added #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t.
Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
diff -pruN -X generic/Documentation/dontdiff generic-orig/include/linux/leds.h generic/include/linux/leds.h
--- generic-orig/include/linux/leds.h 2007-09-04 14:59:51.334686250 +0900
+++ generic/include/linux/leds.h 2007-09-04 14:56:10.676896000 +0900
@@ -13,6 +13,7 @@
#define __LINUX_LEDS_H_INCLUDED
#include <linux/list.h>
+#include <linux/spinlock_types.h>
struct device;
/*
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t
2007-09-04 7:23 [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t Yoichi Yuasa
@ 2007-09-11 5:04 ` Andrew Morton
2007-09-11 8:48 ` Yoichi Yuasa
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2007-09-11 5:04 UTC (permalink / raw)
To: Yoichi Yuasa; +Cc: rpurdie, Linux Kernel Mailing List
On Tue, 4 Sep 2007 16:23:45 +0900 Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
>
> This patch has added #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t.
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
>
> diff -pruN -X generic/Documentation/dontdiff generic-orig/include/linux/leds.h generic/include/linux/leds.h
> --- generic-orig/include/linux/leds.h 2007-09-04 14:59:51.334686250 +0900
> +++ generic/include/linux/leds.h 2007-09-04 14:56:10.676896000 +0900
> @@ -13,6 +13,7 @@
> #define __LINUX_LEDS_H_INCLUDED
>
> #include <linux/list.h>
> +#include <linux/spinlock_types.h>
>
> struct device;
> /*
I think spinlock_types.h is more an internal implementation detail, and
that leds.h should be including plain old <linux/spinlock.h>. Does that
change also fix whatever build error you were seeing?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t
2007-09-11 5:04 ` Andrew Morton
@ 2007-09-11 8:48 ` Yoichi Yuasa
2007-09-11 21:30 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Yoichi Yuasa @ 2007-09-11 8:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: yoichi_yuasa, rpurdie, linux-kernel
On Mon, 10 Sep 2007 22:04:23 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 4 Sep 2007 16:23:45 +0900 Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
>
> >
> > This patch has added #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t.
> >
> > Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> >
> > diff -pruN -X generic/Documentation/dontdiff generic-orig/include/linux/leds.h generic/include/linux/leds.h
> > --- generic-orig/include/linux/leds.h 2007-09-04 14:59:51.334686250 +0900
> > +++ generic/include/linux/leds.h 2007-09-04 14:56:10.676896000 +0900
> > @@ -13,6 +13,7 @@
> > #define __LINUX_LEDS_H_INCLUDED
> >
> > #include <linux/list.h>
> > +#include <linux/spinlock_types.h>
> >
> > struct device;
> > /*
>
> I think spinlock_types.h is more an internal implementation detail, and
> that leds.h should be including plain old <linux/spinlock.h>. Does that
> change also fix whatever build error you were seeing?
Yes it does.
Yoichi
---
This patch has added #include <linux/spinlock.h> to include/linux/leds.h for rwlock_t.
Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
diff -pruN -X generic/Documentation/dontdiff generic-orig/include/linux/leds.h generic/include/linux/leds.h
--- generic-orig/include/linux/leds.h 2007-09-11 15:32:22.723667750 +0900
+++ generic/include/linux/leds.h 2007-09-11 15:28:20.696542000 +0900
@@ -13,6 +13,7 @@
#define __LINUX_LEDS_H_INCLUDED
#include <linux/list.h>
+#include <linux/spinlock.h>
struct device;
/*
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t
2007-09-11 8:48 ` Yoichi Yuasa
@ 2007-09-11 21:30 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2007-09-11 21:30 UTC (permalink / raw)
To: Yoichi Yuasa; +Cc: Andrew Morton, linux-kernel
On Tue, 2007-09-11 at 17:48 +0900, Yoichi Yuasa wrote:
> This patch has added #include <linux/spinlock.h> to include/linux/leds.h for rwlock_t.
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Added to the leds tree[1], thanks.
http://git.o-hand.com/?p=linux-rpurdie-leds;a=shortlog;h=for-mm
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-09-11 21:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-04 7:23 [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t Yoichi Yuasa
2007-09-11 5:04 ` Andrew Morton
2007-09-11 8:48 ` Yoichi Yuasa
2007-09-11 21:30 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox