From: Andrew Morton <akpm@linux-foundation.org>
To: Florian Fainelli <florian.fainelli@telecomint.eu>
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH 3/4] [x86] : Add support for the RDC R-321x SoC
Date: Thu, 25 Oct 2007 14:26:11 -0700 [thread overview]
Message-ID: <20071025142611.a1bb9088.akpm@linux-foundation.org> (raw)
In-Reply-To: <200710161341.32077.florian.fainelli@telecomint.eu>
On Tue, 16 Oct 2007 13:41:31 +0200
Florian Fainelli <florian.fainelli@telecomint.eu> wrote:
> +static struct {
> + struct completion stop;
> + volatile int running;
> + struct timer_list timer;
> + volatile int queue;
> + int default_ticks;
> + unsigned long inuse;
> +} rdc321x_wdt_device;
Why the volatiles? If these actually help then it's probably an indication
that something is wrong in the implementation.
Documentation/volatile-considered-harmful.txt has some details.
prev parent reply other threads:[~2007-10-25 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 11:41 [PATCH 3/4] [x86] : Add support for the RDC R-321x SoC Florian Fainelli
2007-10-25 21:26 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025142611.a1bb9088.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=florian.fainelli@telecomint.eu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox