[Patch1/2] fix wrong proc cpuinfo on x64

[Patch1/2] fix wrong proc cpuinfo on x64

[Zou Nan hai]

in 2.6.24-rc1 kernel, 
The /proc/cpuinfo display is wrong.

One issue is every processor id appears to be 0.

That is because smp_store_cpu_info will set cpuinfo_x86->cpu_index
to cpu id then call identify_cpu
identify_cpu will call early_identify_cpu which set c->cpu_index back to
0.

This patch set cpu_index after identify_cpu to fix the issue.

Signed-off-by: Zou Nan hai <nanhai.zou@intel.com>

--- linux-2.6.24-rc1/arch/x86/kernel/smpboot_64.c	2007-10-29 22:03:05.000000000 -0400
+++ b/arch/x86/kernel/smpboot_64.c	2007-11-05 22:12:57.000000000 -0500
@@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
 	struct cpuinfo_x86 *c = &cpu_data(id);
 
 	*c = boot_cpu_data;
-	c->cpu_index = id;
 	identify_cpu(c);
+	c->cpu_index = id;
 	print_cpu_info(c);
 }
 

Re: [Patch1/2] fix wrong proc cpuinfo on x64

[Andreas Herrmann]

On Tue, Nov 06, 2007 at 03:25:39PM +0800, Zou Nan hai wrote:
> 
> in 2.6.24-rc1 kernel, 
> The /proc/cpuinfo display is wrong.
> 
> One issue is every processor id appears to be 0.
> 
> That is because smp_store_cpu_info will set cpuinfo_x86->cpu_index
> to cpu id then call identify_cpu
> identify_cpu will call early_identify_cpu which set c->cpu_index back to
> 0.

This issue should already be fixed with this patch

http://marc.info/?l=linux-kernel&m=119392088227245


Regards,

Andreas

-- 
Operating | AMD Saxony Limited Liability Company & Co. KG,
  System  | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 Research | Register Court Dresden: HRA 4896, General Partner authorized
  Center  | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
  (OSRC)  | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy