From: Al Viro <viro@ftp.linux.org.uk>
To: Paul Mundt <lethal@linux-sh.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: div64: Rework 64-bit type safety checks in do_div().
Date: Mon, 17 Dec 2007 05:05:12 +0000 [thread overview]
Message-ID: <20071217050512.GY8181@ftp.linux.org.uk> (raw)
In-Reply-To: <20071217032019.GA15449@linux-sh.org>
On Mon, Dec 17, 2007 at 12:20:19PM +0900, Paul Mundt wrote:
> (Adding Ingo to CC regarding kernel/lockdep_proc.c..)
> That seems to be an accurate asessment, yes. If do_div(s64, ...) is buggy
> behaviour, then the current check is fine, and the callsites should be
> corrected. Though if there's code in-tree that relies on s64 do_div, that seems
> to be a more problematic issue.
It is a bug and the only existing callers that manage to work are those that
make sure that signed value is positive. Still asking for trouble...
prev parent reply other threads:[~2007-12-17 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 1:48 div64: Rework 64-bit type safety checks in do_div() Paul Mundt
2007-12-17 3:04 ` Andrew Morton
2007-12-17 3:20 ` Paul Mundt
2007-12-17 5:05 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217050512.GY8181@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox