* [2.6 patch] the scheduled 'time' option removal @ 2008-01-01 13:46 Adrian Bunk 2008-01-01 17:53 ` Jan Engelhardt 2008-01-02 2:07 ` Randy Dunlap 0 siblings, 2 replies; 6+ messages in thread From: Adrian Bunk @ 2008-01-01 13:46 UTC (permalink / raw) To: Randy Dunlap; +Cc: linux-kernel This patch contains the scheduled removal of the 'time' option. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- Documentation/feature-removal-schedule.txt | 8 -------- kernel/printk.c | 13 ------------- 2 files changed, 21 deletions(-) c0ea16c447460698c0e85963310c38fa051f0e23 diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index 20c4c8b..93aac19 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt @@ -233,10 +233,2 @@ Who: Jean Delvare <khali@linux-fr.org> --------------------------- - -What: 'time' kernel boot parameter -When: January 2008 -Why: replaced by 'printk.time=<value>' so that printk timestamps can be - enabled or disabled as needed -Who: Randy Dunlap <randy.dunlap@oracle.com> - ---------------------------- diff --git a/kernel/printk.c b/kernel/printk.c index a30fe33..296c4ea 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -560,15 +560,2 @@ static int printk_time = 0; module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR); - -static int __init printk_time_setup(char *str) -{ - if (*str) - return 0; - printk_time = 1; - printk(KERN_NOTICE "The 'time' option is deprecated and " - "is scheduled for removal in early 2008\n"); - printk(KERN_NOTICE "Use 'printk.time=<value>' instead\n"); - return 1; -} - -__setup("time", printk_time_setup); ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [2.6 patch] the scheduled 'time' option removal 2008-01-01 13:46 [2.6 patch] the scheduled 'time' option removal Adrian Bunk @ 2008-01-01 17:53 ` Jan Engelhardt 2008-01-01 23:57 ` Adrian Bunk 2008-01-02 2:07 ` Randy Dunlap 1 sibling, 1 reply; 6+ messages in thread From: Jan Engelhardt @ 2008-01-01 17:53 UTC (permalink / raw) To: Adrian Bunk; +Cc: Randy Dunlap, linux-kernel On Jan 1 2008 15:46, Adrian Bunk wrote: >index 20c4c8b..93aac19 100644 >--- a/Documentation/feature-removal-schedule.txt >+++ b/Documentation/feature-removal-schedule.txt >@@ -233,10 +233,2 @@ Who: Jean Delvare <khali@linux-fr.org> > --------------------------- >- >-What: 'time' kernel boot parameter >-When: January 2008 >-Why: replaced by 'printk.time=<value>' so that printk timestamps can be >- enabled or disabled as needed >-Who: Randy Dunlap <randy.dunlap@oracle.com> >- I am sure the people who added themselves in the Who: line would have taken care of this soon enough, I mean, it's just 19 hours into the first day :-) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] the scheduled 'time' option removal 2008-01-01 17:53 ` Jan Engelhardt @ 2008-01-01 23:57 ` Adrian Bunk 0 siblings, 0 replies; 6+ messages in thread From: Adrian Bunk @ 2008-01-01 23:57 UTC (permalink / raw) To: Jan Engelhardt; +Cc: Randy Dunlap, linux-kernel On Tue, Jan 01, 2008 at 06:53:54PM +0100, Jan Engelhardt wrote: > > On Jan 1 2008 15:46, Adrian Bunk wrote: > >index 20c4c8b..93aac19 100644 > >--- a/Documentation/feature-removal-schedule.txt > >+++ b/Documentation/feature-removal-schedule.txt > >@@ -233,10 +233,2 @@ Who: Jean Delvare <khali@linux-fr.org> > > --------------------------- > >- > >-What: 'time' kernel boot parameter > >-When: January 2008 > >-Why: replaced by 'printk.time=<value>' so that printk timestamps can be > >- enabled or disabled as needed > >-Who: Randy Dunlap <randy.dunlap@oracle.com> > >- > > I am sure the people who added themselves in the Who: line would have > taken care of this soon enough, I mean, it's just 19 hours into the > first day :-) If Randy decides he wants to submit his own patch for this that wouldn't be a problem for me. :-) cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] the scheduled 'time' option removal 2008-01-01 13:46 [2.6 patch] the scheduled 'time' option removal Adrian Bunk 2008-01-01 17:53 ` Jan Engelhardt @ 2008-01-02 2:07 ` Randy Dunlap 2008-01-20 14:02 ` Adrian Bunk 1 sibling, 1 reply; 6+ messages in thread From: Randy Dunlap @ 2008-01-02 2:07 UTC (permalink / raw) To: Adrian Bunk; +Cc: linux-kernel On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote: > This patch contains the scheduled removal of the 'time' option. > > Signed-off-by: Adrian Bunk <bunk@kernel.org> Thanks. Looks good except that Documentation/kernel-parameters.txt needs a patch also: delete these 3 lines: time Show timing data prefixed to each printk message line [deprecated, see 'printk.time'] then I will Ack it. > --- > > Documentation/feature-removal-schedule.txt | 8 -------- > kernel/printk.c | 13 ------------- > 2 files changed, 21 deletions(-) > > c0ea16c447460698c0e85963310c38fa051f0e23 > diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt > index 20c4c8b..93aac19 100644 > --- a/Documentation/feature-removal-schedule.txt > +++ b/Documentation/feature-removal-schedule.txt > @@ -233,10 +233,2 @@ Who: Jean Delvare <khali@linux-fr.org> > --------------------------- > - > -What: 'time' kernel boot parameter > -When: January 2008 > -Why: replaced by 'printk.time=<value>' so that printk timestamps can be > - enabled or disabled as needed > -Who: Randy Dunlap <randy.dunlap@oracle.com> > - > ---------------------------- > > diff --git a/kernel/printk.c b/kernel/printk.c > index a30fe33..296c4ea 100644 > --- a/kernel/printk.c > +++ b/kernel/printk.c > @@ -560,15 +560,2 @@ static int printk_time = 0; > module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR); > - > -static int __init printk_time_setup(char *str) > -{ > - if (*str) > - return 0; > - printk_time = 1; > - printk(KERN_NOTICE "The 'time' option is deprecated and " > - "is scheduled for removal in early 2008\n"); > - printk(KERN_NOTICE "Use 'printk.time=<value>' instead\n"); > - return 1; > -} > - > -__setup("time", printk_time_setup); --- ~Randy desserts: http://www.xenotime.net/linux/recipes/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] the scheduled 'time' option removal 2008-01-02 2:07 ` Randy Dunlap @ 2008-01-20 14:02 ` Adrian Bunk 2008-01-20 17:31 ` Randy Dunlap 0 siblings, 1 reply; 6+ messages in thread From: Adrian Bunk @ 2008-01-20 14:02 UTC (permalink / raw) To: Randy Dunlap; +Cc: linux-kernel On Tue, Jan 01, 2008 at 06:07:51PM -0800, Randy Dunlap wrote: > On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote: > > > This patch contains the scheduled removal of the 'time' option. > > > > Signed-off-by: Adrian Bunk <bunk@kernel.org> > > Thanks. Looks good except that Documentation/kernel-parameters.txt > needs a patch also: delete these 3 lines: > > time Show timing data prefixed to each printk message line > [deprecated, see 'printk.time'] > > then I will Ack it. Ups, sorry, fixed patch below. cu Adrian <-- snip --> This patch contains the scheduled removal of the 'time' option. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- Documentation/feature-removal-schedule.txt | 8 -------- Documentation/kernel-parameters.txt | 3 --- kernel/printk.c | 13 ------------- 3 files changed, 24 deletions(-) 84ec4030ca61db7f80b6d761acb7d12255cc5cf6 diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index 20c4c8b..93aac19 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt @@ -233,14 +233,6 @@ Who: Jean Delvare <khali@linux-fr.org> --------------------------- -What: 'time' kernel boot parameter -When: January 2008 -Why: replaced by 'printk.time=<value>' so that printk timestamps can be - enabled or disabled as needed -Who: Randy Dunlap <randy.dunlap@oracle.com> - ---------------------------- - What: drivers depending on OSS_OBSOLETE When: options in 2.6.23, code in 2.6.25 Why: obsolete OSS drivers diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index c417877..79afb11 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -1899,9 +1899,6 @@ and is between 256 and 4096 characters. It is defined in the file <deci-seconds>: poll all this frequency 0: no polling (default) - time Show timing data prefixed to each printk message line - [deprecated, see 'printk.time'] - tipar.timeout= [HW,PPT] Set communications timeout in tenths of a second (default 15). diff --git a/kernel/printk.c b/kernel/printk.c index 89011bf..3aa8749 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -560,19 +560,6 @@ static int printk_time = 0; #endif module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR); -static int __init printk_time_setup(char *str) -{ - if (*str) - return 0; - printk_time = 1; - printk(KERN_NOTICE "The 'time' option is deprecated and " - "is scheduled for removal in early 2008\n"); - printk(KERN_NOTICE "Use 'printk.time=<value>' instead\n"); - return 1; -} - -__setup("time", printk_time_setup); - __attribute__((weak)) unsigned long long printk_clock(void) { return sched_clock(); ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [2.6 patch] the scheduled 'time' option removal 2008-01-20 14:02 ` Adrian Bunk @ 2008-01-20 17:31 ` Randy Dunlap 0 siblings, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2008-01-20 17:31 UTC (permalink / raw) To: Adrian Bunk; +Cc: linux-kernel Adrian Bunk wrote: > On Tue, Jan 01, 2008 at 06:07:51PM -0800, Randy Dunlap wrote: >> On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote: >> >>> This patch contains the scheduled removal of the 'time' option. >>> >>> Signed-off-by: Adrian Bunk <bunk@kernel.org> >> Thanks. Looks good except that Documentation/kernel-parameters.txt >> needs a patch also: delete these 3 lines: >> >> time Show timing data prefixed to each printk message line >> [deprecated, see 'printk.time'] >> >> then I will Ack it. > > Ups, sorry, fixed patch below. > > cu > Adrian > > > <-- snip --> > > > This patch contains the scheduled removal of the 'time' option. > > Signed-off-by: Adrian Bunk <bunk@kernel.org> Acked-by: Randy Dunlap <randy.dunlap@oracle.com> Thanks, Adrian. > --- > > Documentation/feature-removal-schedule.txt | 8 -------- > Documentation/kernel-parameters.txt | 3 --- > kernel/printk.c | 13 ------------- > 3 files changed, 24 deletions(-) > > 84ec4030ca61db7f80b6d761acb7d12255cc5cf6 > diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt > index 20c4c8b..93aac19 100644 > --- a/Documentation/feature-removal-schedule.txt > +++ b/Documentation/feature-removal-schedule.txt > @@ -233,14 +233,6 @@ Who: Jean Delvare <khali@linux-fr.org> > > --------------------------- > > -What: 'time' kernel boot parameter > -When: January 2008 > -Why: replaced by 'printk.time=<value>' so that printk timestamps can be > - enabled or disabled as needed > -Who: Randy Dunlap <randy.dunlap@oracle.com> > - > ---------------------------- > - > What: drivers depending on OSS_OBSOLETE > When: options in 2.6.23, code in 2.6.25 > Why: obsolete OSS drivers > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index c417877..79afb11 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -1899,9 +1899,6 @@ and is between 256 and 4096 characters. It is defined in the file > <deci-seconds>: poll all this frequency > 0: no polling (default) > > - time Show timing data prefixed to each printk message line > - [deprecated, see 'printk.time'] > - > tipar.timeout= [HW,PPT] > Set communications timeout in tenths of a second > (default 15). > diff --git a/kernel/printk.c b/kernel/printk.c > index 89011bf..3aa8749 100644 > --- a/kernel/printk.c > +++ b/kernel/printk.c > @@ -560,19 +560,6 @@ static int printk_time = 0; > #endif > module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR); > > -static int __init printk_time_setup(char *str) > -{ > - if (*str) > - return 0; > - printk_time = 1; > - printk(KERN_NOTICE "The 'time' option is deprecated and " > - "is scheduled for removal in early 2008\n"); > - printk(KERN_NOTICE "Use 'printk.time=<value>' instead\n"); > - return 1; > -} > - > -__setup("time", printk_time_setup); > - > __attribute__((weak)) unsigned long long printk_clock(void) > { > return sched_clock(); > -- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-01-20 17:32 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-01-01 13:46 [2.6 patch] the scheduled 'time' option removal Adrian Bunk 2008-01-01 17:53 ` Jan Engelhardt 2008-01-01 23:57 ` Adrian Bunk 2008-01-02 2:07 ` Randy Dunlap 2008-01-20 14:02 ` Adrian Bunk 2008-01-20 17:31 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox