[BUG] x86: duplicated TIF number

[BUG] x86: duplicated TIF number

[Mathieu Desnoyers]

Hi,

I wonder if this is expected ? (in current 2.6.24-git)

commit 7e9916040b3020d0f36d68bb7512e3b80b623097
and commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4

Both use the same TIF number (25) in thread_info_64.h.

Mathieu


-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

[PATCH] Fix x86_64 duplicated TIF

[Mathieu Desnoyers]

I wonder if this is expected ? (in current 2.6.24-git)

commit 7e9916040b3020d0f36d68bb7512e3b80b623097
and commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4

Both use the same TIF number (25) in thread_info_64.h.

This patch changes the TIF ids.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
---
 include/asm-x86/thread_info_64.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6-lttng/include/asm-x86/thread_info_64.h
===================================================================
--- linux-2.6-lttng.orig/include/asm-x86/thread_info_64.h	2008-01-30 09:52:56.000000000 -0500
+++ linux-2.6-lttng/include/asm-x86/thread_info_64.h	2008-01-30 09:53:14.000000000 -0500
@@ -123,8 +123,8 @@ static inline struct thread_info *stack_
 #define TIF_FREEZE		23	/* is freezing for suspend */
 #define TIF_FORCED_TF		24	/* true if TF in eflags artificially */
 #define TIF_DEBUGCTLMSR		25	/* uses thread_struct.debugctlmsr */
-#define TIF_DS_AREA_MSR	25      /* uses thread_struct.ds_area_msr */
-#define TIF_BTS_TRACE_TS	26      /* record scheduling event timestamps */
+#define TIF_DS_AREA_MSR		26      /* uses thread_struct.ds_area_msr */
+#define TIF_BTS_TRACE_TS	27      /* record scheduling event timestamps */
 
 #define _TIF_SYSCALL_TRACE	(1<<TIF_SYSCALL_TRACE)
 #define _TIF_SIGPENDING		(1<<TIF_SIGPENDING)

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

Re: [PATCH] Fix x86_64 duplicated TIF

[Ingo Molnar]

* Mathieu Desnoyers <compudj@krystal.dyndns.org> wrote:

> I wonder if this is expected ? (in current 2.6.24-git)
> 
> commit 7e9916040b3020d0f36d68bb7512e3b80b623097
> and commit eee3af4a2c83a97fff107ddc445d9df6fded9ce4
> 
> Both use the same TIF number (25) in thread_info_64.h.

>  #define TIF_DEBUGCTLMSR		25	/* uses thread_struct.debugctlmsr */
> -#define TIF_DS_AREA_MSR	25      /* uses thread_struct.ds_area_msr */
> -#define TIF_BTS_TRACE_TS	26      /* record scheduling event timestamps */
> +#define TIF_DS_AREA_MSR		26      /* uses thread_struct.ds_area_msr */
> +#define TIF_BTS_TRACE_TS	27      /* record scheduling event timestamps */

thanks, applied.

	Ingo