* [PATCH] x25_asy: Fix ref count rule violation
@ 2008-02-08 15:29 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2008-02-08 15:29 UTC (permalink / raw)
To: akpm, linux-kernel
x25_asy does not take an ldisc reference before calling the flush method.
Fix it to use the helper function we provide.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/net/wan/x25_asy.c linux-2.6.24-mm1/drivers/net/wan/x25_asy.c
--- linux.vanilla-2.6.24-mm1/drivers/net/wan/x25_asy.c 2008-02-06 14:13:27.000000000 +0000
+++ linux-2.6.24-mm1/drivers/net/wan/x25_asy.c 2008-02-06 14:34:55.000000000 +0000
@@ -554,6 +554,7 @@
static int x25_asy_open_tty(struct tty_struct *tty)
{
struct x25_asy *sl = (struct x25_asy *) tty->disc_data;
+ struct tty_ldisc *ld;
int err;
/* First make sure we're not already connected. */
@@ -572,9 +573,7 @@
if (tty->driver->flush_buffer) {
tty->driver->flush_buffer(tty);
}
- if (tty->ldisc.flush_buffer) {
- tty->ldisc.flush_buffer(tty);
- }
+ tty_ldisc_flush(tty);
/* Restore default settings */
sl->dev->type = ARPHRD_X25;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-08 15:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-08 15:29 [PATCH] x25_asy: Fix ref count rule violation Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox