From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make marker_debug static
Date: Thu, 14 Feb 2008 17:37:28 -0500 [thread overview]
Message-ID: <20080214223728.GA18772@Krystal> (raw)
In-Reply-To: <20080214212349.GD23227@cs181133002.pp.htv.fi>
* Adrian Bunk (bunk@kernel.org) wrote:
> With the needlessly global marker_debug being static gcc can optimize
> the unused code away.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Thanks,
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> ---
> 91577cc8ac60bf9003d0dd037a231db363003740 diff --git a/kernel/marker.c b/kernel/marker.c
> index c4c2cd8..133bdbb 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -28,7 +28,7 @@ extern struct marker __start___markers[];
> extern struct marker __stop___markers[];
>
> /* Set to 1 to enable marker debug output */
> -const int marker_debug;
> +static const int marker_debug;
>
> /*
> * markers_mutex nests inside module_mutex. Markers mutex protects the builtin
>
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
prev parent reply other threads:[~2008-02-14 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 21:23 [2.6 patch] make marker_debug static Adrian Bunk
2008-02-14 22:37 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214223728.GA18772@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox