* [2.6 patch] make marker_debug static
@ 2008-02-14 21:23 Adrian Bunk
2008-02-14 22:37 ` Mathieu Desnoyers
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-02-14 21:23 UTC (permalink / raw)
To: Mathieu Desnoyers; +Cc: linux-kernel
With the needlessly global marker_debug being static gcc can optimize
the unused code away.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
91577cc8ac60bf9003d0dd037a231db363003740 diff --git a/kernel/marker.c b/kernel/marker.c
index c4c2cd8..133bdbb 100644
--- a/kernel/marker.c
+++ b/kernel/marker.c
@@ -28,7 +28,7 @@ extern struct marker __start___markers[];
extern struct marker __stop___markers[];
/* Set to 1 to enable marker debug output */
-const int marker_debug;
+static const int marker_debug;
/*
* markers_mutex nests inside module_mutex. Markers mutex protects the builtin
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] make marker_debug static
2008-02-14 21:23 [2.6 patch] make marker_debug static Adrian Bunk
@ 2008-02-14 22:37 ` Mathieu Desnoyers
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Desnoyers @ 2008-02-14 22:37 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
* Adrian Bunk (bunk@kernel.org) wrote:
> With the needlessly global marker_debug being static gcc can optimize
> the unused code away.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Thanks,
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> ---
> 91577cc8ac60bf9003d0dd037a231db363003740 diff --git a/kernel/marker.c b/kernel/marker.c
> index c4c2cd8..133bdbb 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -28,7 +28,7 @@ extern struct marker __start___markers[];
> extern struct marker __stop___markers[];
>
> /* Set to 1 to enable marker debug output */
> -const int marker_debug;
> +static const int marker_debug;
>
> /*
> * markers_mutex nests inside module_mutex. Markers mutex protects the builtin
>
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-14 22:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-14 21:23 [2.6 patch] make marker_debug static Adrian Bunk
2008-02-14 22:37 ` Mathieu Desnoyers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox