[PATCH] cgroup: fix default notify_on_release setting

[PATCH] cgroup: fix default notify_on_release setting

[Li Zefan]

The documentation says the default value of notify_on_release of
a child cgroup is inherited from its parent, which is reasonable,
but the implementation just sets the flag disabled.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/cgroup.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index d8abe99..e9c2fb0 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2232,7 +2232,6 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
 
 	mutex_lock(&cgroup_mutex);
 
-	cgrp->flags = 0;
 	INIT_LIST_HEAD(&cgrp->sibling);
 	INIT_LIST_HEAD(&cgrp->children);
 	INIT_LIST_HEAD(&cgrp->css_sets);
@@ -2242,6 +2241,9 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
 	cgrp->root = parent->root;
 	cgrp->top_cgroup = parent->top_cgroup;
 
+	if (notify_on_release(parent))
+		set_bit(CGRP_NOTIFY_ON_RELEASE, &cgrp->flags);
+
 	for_each_subsys(root, ss) {
 		struct cgroup_subsys_state *css = ss->create(ss, cgrp);
 		if (IS_ERR(css)) {
-- 
1.5.4.rc3

Re: [PATCH] cgroup: fix default notify_on_release setting

[Paul Menage]

On Sun, Feb 24, 2008 at 9:53 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> The documentation says the default value of notify_on_release of
>  a child cgroup is inherited from its parent, which is reasonable,
>  but the implementation just sets the flag disabled.
>
>  Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>

Acked-by: Paul Menage <menage@google.com>

Yes, I guess it makes sense to follow the original cpusets behaviour.
I think that got lost when the notify-on-release functionality was
temporarily removed during cgroups development.

>  ---
>   kernel/cgroup.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
>  diff --git a/kernel/cgroup.c b/kernel/cgroup.c
>  index d8abe99..e9c2fb0 100644
>  --- a/kernel/cgroup.c
>  +++ b/kernel/cgroup.c
>  @@ -2232,7 +2232,6 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
>
>         mutex_lock(&cgroup_mutex);
>
>  -       cgrp->flags = 0;
>         INIT_LIST_HEAD(&cgrp->sibling);
>         INIT_LIST_HEAD(&cgrp->children);
>         INIT_LIST_HEAD(&cgrp->css_sets);
>  @@ -2242,6 +2241,9 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
>         cgrp->root = parent->root;
>         cgrp->top_cgroup = parent->top_cgroup;
>
>  +       if (notify_on_release(parent))
>  +               set_bit(CGRP_NOTIFY_ON_RELEASE, &cgrp->flags);
>  +
>         for_each_subsys(root, ss) {
>                 struct cgroup_subsys_state *css = ss->create(ss, cgrp);
>                 if (IS_ERR(css)) {
>  --
>  1.5.4.rc3
>
>

Re: [PATCH] cgroup: fix default notify_on_release setting

[Paul Jackson]

>  @@ -2242,6 +2241,9 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
>         cgrp->root = parent->root;
>         cgrp->top_cgroup = parent->top_cgroup;
>
>  +       if (notify_on_release(parent))
>  +               set_bit(CGRP_NOTIFY_ON_RELEASE, &cgrp->flags);


Good catch, Li Zefan - thanks.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214