From: Andi Kleen <andi@firstfloor.org>
To: akpm@osdl.org, wli@holomorphy.com, linux-kernel@vger.kernel.org
Subject: [PATCH] Terminate hugetlbfs mount argument list
Date: Tue, 11 Mar 2008 23:42:04 +0100 [thread overview]
Message-ID: <20080311224204.GA16719@basil.nowhere.org> (raw)
Terminate hugetlbfs mount argument list
[2.6.25 candidate I believe]
The match_table_t for the mount arguments in hugetlbfs wasn't
terminated as match_tokens expect. I didn't see a crash just code
audit, but it's still safer to terminate it in case the variables after
that in .data are not NULL.
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/fs/hugetlbfs/inode.c
===================================================================
--- linux.orig/fs/hugetlbfs/inode.c
+++ linux/fs/hugetlbfs/inode.c
@@ -63,6 +63,7 @@ static match_table_t tokens = {
{Opt_uid, "uid=%u"},
{Opt_gid, "gid=%u"},
{Opt_err, NULL},
+ {},
};
static void huge_pagevec_release(struct pagevec *pvec)
next reply other threads:[~2008-03-11 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 22:42 Andi Kleen [this message]
2008-03-11 22:48 ` [PATCH] Terminate hugetlbfs mount argument list Roland Dreier
2008-03-11 22:56 ` Andi Kleen
2008-03-11 23:26 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080311224204.GA16719@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox