From: Andi Kleen <andi@firstfloor.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Andi Kleen <andi@firstfloor.org>,
akpm@osdl.org, wli@holomorphy.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Terminate hugetlbfs mount argument list
Date: Tue, 11 Mar 2008 23:56:23 +0100 [thread overview]
Message-ID: <20080311225623.GE428@one.firstfloor.org> (raw)
In-Reply-To: <adabq5klvw1.fsf@cisco.com>
On Tue, Mar 11, 2008 at 03:48:46PM -0700, Roland Dreier wrote:
> > The match_table_t for the mount arguments in hugetlbfs wasn't
> > terminated as match_tokens expect. I didn't see a crash just code
> > audit, but it's still safer to terminate it in case the variables after
> > that in .data are not NULL.
>
> I think you're misunderstanding the match_token() interface. The
> comment before match_token() says:
Hmm indeed I did. To my defense it's a weird unusual coding pattern
that tricked me. What good is it to give terminator elements own enum values?
-Andi
next prev parent reply other threads:[~2008-03-11 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 22:42 [PATCH] Terminate hugetlbfs mount argument list Andi Kleen
2008-03-11 22:48 ` Roland Dreier
2008-03-11 22:56 ` Andi Kleen [this message]
2008-03-11 23:26 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080311225623.GE428@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox