From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Ralf Baechle <ralf@linux-mips.org>,
David Howells <dhowells@redhat.com>
Subject: Re: pm_register() and pm_send_all()
Date: Thu, 13 Mar 2008 22:04:11 +0100 [thread overview]
Message-ID: <20080313210411.GF4949@elf.ucw.cz> (raw)
In-Reply-To: <200803132154.59910.rjw@sisk.pl>
On Thu 2008-03-13 21:54:58, Rafael J. Wysocki wrote:
> On Thursday, 13 of March 2008, Pavel Machek wrote:
> > On Wed 2008-03-12 15:00:42, Andrew Morton wrote:
> > >
> > > This:
> > >
> > > kernel/power/pm.c:203: warning: 'pm_register' is deprecated (declared at kernel/power/pm.c:62)
> > > kernel/power/pm.c:203: warning: 'pm_register' is deprecated (declared at kernel/power/pm.c:62)
> > > kernel/power/pm.c:204: warning: 'pm_send_all' is deprecated (declared at kernel/power/pm.c:178)
> > > kernel/power/pm.c:204: warning: 'pm_send_all' is deprecated (declared at kernel/power/pm.c:178)
> > >
> > > is getting a bit boring. These were marked deprecated at least three years
> > > ago.
> > >
> > >
> > > pm_register() no longer has any callers and afacit can be removed
> > > immediately.
> > >
> > > pm_send_all() has just a handful of callers:
> > >
> > > arch/x86/kernel/apm_32.c
> > > arch/mips/au1000/common/power.c
> > > arch/frv/kernel/pm.c
> >
> > AFAICT pm_send_all is a nop when noone uses pm_register...
>
> Apparently on 2.6.24 it's not used anywehere, at least according to LXR.
>
> > Hmm.. can we just force CONFIG_PM_LEGACY=n, and see what happens?
>
> Do you want me to push this patch and the following one from Ralf to
> Len?
Yes... I think we can kill pm_send_all etc...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/
next prev parent reply other threads:[~2008-03-13 21:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 22:00 pm_register() and pm_send_all() Andrew Morton
2008-03-12 22:54 ` Rafael J. Wysocki
2008-03-13 9:28 ` Pavel Machek
2008-03-13 12:28 ` Ralf Baechle
2008-03-13 14:19 ` Ralf Baechle
2008-03-13 18:06 ` Pavel Machek
2008-03-13 20:54 ` Rafael J. Wysocki
2008-03-13 21:04 ` Pavel Machek [this message]
2008-03-21 11:42 ` Ingo Molnar
2008-03-13 12:31 ` David Howells
2008-03-13 16:07 ` Andrew Morton
2008-03-13 18:05 ` Pavel Machek
2008-03-13 18:26 ` Andrew Morton
2008-03-14 8:04 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313210411.GF4949@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ralf@linux-mips.org \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox