public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	David Howells <dhowells@redhat.com>
Subject: Re: pm_register() and pm_send_all()
Date: Thu, 13 Mar 2008 14:19:17 +0000	[thread overview]
Message-ID: <20080313141917.GA4117@linux-mips.org> (raw)
In-Reply-To: <20080313122823.GA19415@linux-mips.org>

On Thu, Mar 13, 2008 at 12:28:23PM +0000, Ralf Baechle wrote:

> Looks correct to me, thus ACK.
> 
> Spinning that a little further I wonder how useful the rest of the
> Alchemy code - which seems to only deal with devices - is.  If at all.
> I'm going to check with some Alchemy users if that code actually works or
> can be removed.  I think the latter.  Also there is the APM emulation
> available which provides similar functionality.

So here a patch do cleanup a part.  Probably more to come

From: Ralf Baechle <ralf@linux-mips.org>

[MIPS] Alchey: Crapectomy after removal of pm_send_all calls.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

 arch/mips/au1000/common/power.c |   20 --------------------
 1 file changed, 20 deletions(-)

Index: linux-mips/arch/mips/au1000/common/power.c
===================================================================
--- linux-mips.orig/arch/mips/au1000/common/power.c
+++ linux-mips/arch/mips/au1000/common/power.c
@@ -283,18 +283,6 @@ static int pm_do_sleep(ctl_table * ctl, 
 	return 0;
 }
 
-static int pm_do_suspend(ctl_table * ctl, int write, struct file *file,
-			 void __user *buffer, size_t * len, loff_t *ppos)
-{
-	if (!write) {
-		*len = 0;
-	} else {
-		suspend_mode = 1;
-	}
-	return 0;
-}
-
-
 static int pm_do_freq(ctl_table * ctl, int write, struct file *file,
 		      void __user *buffer, size_t * len, loff_t *ppos)
 {
@@ -408,14 +396,6 @@ static int pm_do_freq(ctl_table * ctl, i
 
 static struct ctl_table pm_table[] = {
 	{
-		.ctl_name 	= CTL_UNNUMBERED,
-		.procname	= "suspend",
-		.data		= NULL,
-		.maxlen		= 0,
-		.mode		= 0600,
-		.proc_handler	= &pm_do_suspend
-	},
-	{
 		.ctl_name	= CTL_UNNUMBERED,
 		.procname	= "sleep",
 		.data		= NULL,

  reply	other threads:[~2008-03-13 14:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-12 22:00 pm_register() and pm_send_all() Andrew Morton
2008-03-12 22:54 ` Rafael J. Wysocki
2008-03-13  9:28 ` Pavel Machek
2008-03-13 12:28   ` Ralf Baechle
2008-03-13 14:19     ` Ralf Baechle [this message]
2008-03-13 18:06       ` Pavel Machek
2008-03-13 20:54   ` Rafael J. Wysocki
2008-03-13 21:04     ` Pavel Machek
2008-03-21 11:42   ` Ingo Molnar
2008-03-13 12:31 ` David Howells
2008-03-13 16:07   ` Andrew Morton
2008-03-13 18:05   ` Pavel Machek
2008-03-13 18:26     ` Andrew Morton
2008-03-14  8:04       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080313141917.GA4117@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox