* [PATCH 2.6.25-rc6-git2] drm: fix printk format warning
@ 2008-03-18 21:14 Randy Dunlap
2008-03-24 3:08 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2008-03-18 21:14 UTC (permalink / raw)
To: lkml, akpm; +Cc: airlied, dri-devel
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix gcc printk format warning:
drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
but doesn't the %08 leave room for truncation?
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/char/drm/ati_pcigart.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.25-rc6-git2.orig/drivers/char/drm/ati_pcigart.c
+++ linux-2.6.25-rc6-git2/drivers/char/drm/ati_pcigart.c
@@ -122,8 +122,9 @@ int drm_ati_pcigart_init(struct drm_devi
} else {
address = gart_info->addr;
bus_address = gart_info->bus_addr;
- DRM_DEBUG("PCI: Gart Table: VRAM %08X mapped at %08lX\n",
- bus_address, (unsigned long)address);
+ DRM_DEBUG("PCI: Gart Table: VRAM %08llX mapped at %08lX\n",
+ (unsigned long long)bus_address,
+ (unsigned long)address);
}
pci_gart = (u32 *) address;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.25-rc6-git2] drm: fix printk format warning
2008-03-18 21:14 [PATCH 2.6.25-rc6-git2] drm: fix printk format warning Randy Dunlap
@ 2008-03-24 3:08 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2008-03-24 3:08 UTC (permalink / raw)
To: lkml; +Cc: akpm, airlied, dri-devel
ping.
On Tue, 18 Mar 2008 14:14:11 -0700 Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix gcc printk format warning:
> drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
>
> but doesn't the %08 leave room for truncation?
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/char/drm/ati_pcigart.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- linux-2.6.25-rc6-git2.orig/drivers/char/drm/ati_pcigart.c
> +++ linux-2.6.25-rc6-git2/drivers/char/drm/ati_pcigart.c
> @@ -122,8 +122,9 @@ int drm_ati_pcigart_init(struct drm_devi
> } else {
> address = gart_info->addr;
> bus_address = gart_info->bus_addr;
> - DRM_DEBUG("PCI: Gart Table: VRAM %08X mapped at %08lX\n",
> - bus_address, (unsigned long)address);
> + DRM_DEBUG("PCI: Gart Table: VRAM %08llX mapped at %08lX\n",
> + (unsigned long long)bus_address,
> + (unsigned long)address);
> }
>
> pci_gart = (u32 *) address;
> --
---
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-24 3:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-18 21:14 [PATCH 2.6.25-rc6-git2] drm: fix printk format warning Randy Dunlap
2008-03-24 3:08 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox