[PATCH 0/3] x86: more section mismatch fixes

[PATCH 0/3] x86: more section mismatch fixes

[Jacek Luczak]

Hi,

those are patches which fixes some section mismatch stuff in 32-bit part of arch/x86.

@Ingo, I hope that this time everything will be perfect ;-)


-Jacek

[PATCH 1/3] x86: trampoline_32.S - switch to .cpuinit.data

[Jacek Luczak]

This patch fixes section mismatch warnings of __cpuinit setup_trampoline() on 32-bit host.

Signed-off-by: Jacek Luczak <luczak.jacek@gmail.com>

---
 trampoline_32.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 
diff --git a/arch/x86/kernel/trampoline_32.S b/arch/x86/kernel/trampoline_32.S
index 6458067..d8ccc3c 100644
--- a/arch/x86/kernel/trampoline_32.S
+++ b/arch/x86/kernel/trampoline_32.S
@@ -33,7 +33,7 @@
 
 /* We can free up trampoline after bootup if cpu hotplug is not supported. */
 #ifndef CONFIG_HOTPLUG_CPU
-.section ".init.data","aw",@progbits
+.section ".cpuinit.data","aw",@progbits
 #else
 .section .rodata,"a",@progbits
 #endif

[PATCH 2/3] x86: uniq_ioapic_id - fix section mismatch warning

[Jacek Luczak]

Fix folowing warning:
WARNING: arch/x86/kernel/built-in.o(.text+0x10799): Section mismatch in reference from the function uniq_ioapic_id()

uniq_ioapic_id() is only used by __init mp_register_ioapic(). Annotate uniq_ioapic_id() with __init.

Signed-off-by: Jacek Luczak <luczak.jacek@gmail.com>

---
 mpparse.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 70744e3..d885f8f 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -820,7 +820,7 @@ static int mp_find_ioapic(int gsi)
 	return -1;
 }
 
-static u8 uniq_ioapic_id(u8 id)
+static u8 __init uniq_ioapic_id(u8 id)
 {
 #ifdef CONFIG_X86_32
 	if ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) &&

[PATCH 3/3] x86: unlock_ExtINT_logic() - fix section mismatch warnings

[Jacek Luczak]

Fix following warning:
WARNING: arch/x86/kernel/built-in.o(.text+0x12cc9): Section mismatch in reference from the function unlock_ExtINT_logic()

unlock_ExtINT_logic() is only used by __init check_timer(). Annotate unlock_ExtINT_logic() witch __init.

Signed-off-by: Jacek Luczak <luczak.jacek@gmail.com>

---
 io_apic_32.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c
index 2e2f420..696b8e4 100644
--- a/arch/x86/kernel/io_apic_32.c
+++ b/arch/x86/kernel/io_apic_32.c
@@ -2068,7 +2068,7 @@ static void __init setup_nmi(void)
  * cycles as some i82489DX-based boards have glue logic that keeps the
  * 8259A interrupt line asserted until INTA.  --macro
  */
-static inline void unlock_ExtINT_logic(void)
+static inline void __init unlock_ExtINT_logic(void)
 {
 	int apic, pin, i;
 	struct IO_APIC_route_entry entry0, entry1;

Re: [PATCH 0/3] x86: more section mismatch fixes

[Sam Ravnborg]

On Sat, Apr 12, 2008 at 05:37:39PM +0200, Jacek Luczak wrote:
> 
> Hi,
> 
> those are patches which fixes some section mismatch stuff in 32-bit part of arch/x86.

Hi Jacek.

Thanks for taking your time to look inot these and fix them!

	Sam

Re: [PATCH 0/3] x86: more section mismatch fixes

[Ingo Molnar]

* Jacek Luczak <difrost.kernel@gmail.com> wrote:

> Hi,
> 
> those are patches which fixes some section mismatch stuff in 32-bit 
> part of arch/x86.

thanks Jacek, applied.

	Ingo