Re: Fw: [2.6 patch] make cifs_dfs_automount_list static

Re: Fw: [2.6 patch] make cifs_dfs_automount_list static

[Steve French]

Merged into cifs-2.6.git tree

> Adrian Bunk <bunk@kernel.org>
> 04/14/2008 01:13 PM
>
> To
> Igor Mammedov <niallain@gmail.com>, Steven French/Austin/IBM@IBMUS
> cc
> linux-cifs-client@lists.samba.org, linux-kernel@vger.kernel.org
> Subject
> [2.6 patch] make cifs_dfs_automount_list static
>
>
> This patch makes the needlessly global cifs_dfs_automount_list static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> This patch has been sent on:
> - 31 Mar 2008
>
>  fs/cifs/cifs_dfs_ref.c |    2 +-
>  fs/cifs/cifsfs.h       |    1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> 7bd42d48fcdcda24f48c025ca4bfd31b2bf77d46 diff --git
> a/fs/cifs/cifs_dfs_ref.c b/fs/cifs/cifs_dfs_ref.c
> index a1a95b0..33719df 100644
> --- a/fs/cifs/cifs_dfs_ref.c
> +++ b/fs/cifs/cifs_dfs_ref.c
> @@ -23,7 +23,7 @@
>  #include "dns_resolve.h"
>  #include "cifs_debug.h"
>
> -LIST_HEAD(cifs_dfs_automount_list);
> +static LIST_HEAD(cifs_dfs_automount_list);
>
>  /*
>  * DFS functions
> diff --git a/fs/cifs/cifsfs.h b/fs/cifs/cifsfs.h
> index 6897830..dbaefc3 100644
> --- a/fs/cifs/cifsfs.h
> +++ b/fs/cifs/cifsfs.h
> @@ -62,7 +62,6 @@ extern int cifs_setattr(struct dentry *, struct iattr
> *);
>
>  extern const struct inode_operations cifs_file_inode_ops;
>  extern const struct inode_operations cifs_symlink_inode_ops;
> -extern struct list_head cifs_dfs_automount_list;
>  extern struct inode_operations cifs_dfs_referral_inode_operations;
>
>

-- 
Thanks,

Steve

Re: Fw: [2.6 patch] make cifs_dfs_automount_list static

[Al Viro]

On Tue, Apr 15, 2008 at 10:58:06PM -0500, Steve French wrote:
> Merged into cifs-2.6.git tree
> 
> > Adrian Bunk <bunk@kernel.org>
> > 04/14/2008 01:13 PM
> >
> > To
> > Igor Mammedov <niallain@gmail.com>, Steven French/Austin/IBM@IBMUS
> > cc
> > linux-cifs-client@lists.samba.org, linux-kernel@vger.kernel.org
> > Subject
> > [2.6 patch] make cifs_dfs_automount_list static
> >
> >
> > This patch makes the needlessly global cifs_dfs_automount_list static.

This only hides the real problem, namely that logics in the user of said
list is FUBAR.

What kind of eviction policy does cifs want?  "Try to kick all such
mounts out whenever somebody does umount(2) on any mounted cifs instance"?
That's bloody odd, to put it mildly...  "Don't kick them out until
somebody tries to umount cifs instance they are mounted on"?  That's
done automatically from VFS these days (and should've been done that
way as soon as that kind of automounts had been introduced).  "Done
frequently enough"?  Then you want timer, like e.g. NFS does...