* [PATCH -next] x86/trace: uses/depends on PCI
@ 2008-04-16 17:44 Randy Dunlap
2008-04-16 18:38 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2008-04-16 17:44 UTC (permalink / raw)
To: lkml; +Cc: linux-next, mingo, tglx
From: Randy Dunlap <randy.dunlap@oracle.com>
Don't try to build mmiotrace when CONFIG_PCI=n.
next-20080416/kernel/trace/trace_mmiotrace.c: In function 'mmio_print_pcidev':
next-20080416/kernel/trace/trace_mmiotrace.c:62: error: implicit declaration of function 'pci_dev_driver'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/x86/Kconfig.debug | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- next-20080416.orig/arch/x86/Kconfig.debug
+++ next-20080416/arch/x86/Kconfig.debug
@@ -186,7 +186,7 @@ config MMIOTRACE_HOOKS
config MMIOTRACE
bool "Memory mapped IO tracing"
- depends on DEBUG_KERNEL
+ depends on DEBUG_KERNEL && PCI
select TRACING
select MMIOTRACE_HOOKS
default y
@@ -194,7 +194,7 @@ config MMIOTRACE
Mmiotrace traces Memory Mapped I/O access and is meant for
debugging and reverse engineering. It is called from the ioremap
implementation and works via page faults. Tracing is disabled by
- default and can be enabled run-time.
+ default and can be enabled at run-time.
See Documentation/tracers/mmiotrace.txt.
If you are not helping to develop drivers, say N.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] x86/trace: uses/depends on PCI
2008-04-16 17:44 [PATCH -next] x86/trace: uses/depends on PCI Randy Dunlap
@ 2008-04-16 18:38 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-04-16 18:38 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, linux-next, mingo, tglx
* Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Don't try to build mmiotrace when CONFIG_PCI=n.
>
> next-20080416/kernel/trace/trace_mmiotrace.c: In function 'mmio_print_pcidev':
> next-20080416/kernel/trace/trace_mmiotrace.c:62: error: implicit declaration of function 'pci_dev_driver'
thanks Randy, applied.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-16 18:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-16 17:44 [PATCH -next] x86/trace: uses/depends on PCI Randy Dunlap
2008-04-16 18:38 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox