From: Rodney Lorrimar <rodney@rodney.id.au>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Pavel Machek <pavel@suse.cz>,
jikos@suse.cz, Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew McNabb <amcnabb@mcnabbs.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Input: adbhid - restore_capslock_events fixes
Date: Wed, 23 Apr 2008 12:14:16 +0200 [thread overview]
Message-ID: <20080423101416.GA4735@solaria.local> (raw)
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
Hi Dmitry,
Would you consider these for review and inclusion in the input tree?
They fix 2 out of 3 problems I know of in the simulation of capslock
up/down key events on Apple laptop keyboards. The third problem - that
sometimes the capslock key gets stuck down - I haven't looked at
properly yet, but I know that the "capslock key up" packet is never
received by adbhid_keyboard_input so the problem is in adb.c or
via-pmu.c, or possibly the hardware never sends the event at all.
Pavel Machek suggested removing the parameter, and I would do this
after fixing the third problem. This would probably happen after the
once-or-twice-a-day event of stuck capslock annoys me enough to have a
deeper look.
Thanks,
Rodney
Rodney Lorrimar (2):
Input: adbhid - fix capslock key state after suspend
Input: adbhid - capslock and power button fix
drivers/macintosh/adbhid.c | 58 +++++++++++++++++++++++++++++++++++++-------
1 files changed, 49 insertions(+), 9 deletions(-)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2008-04-23 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 10:14 Rodney Lorrimar [this message]
2008-04-25 15:09 ` [PATCH 0/2] Input: adbhid - restore_capslock_events fixes Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423101416.GA4735@solaria.local \
--to=rodney@rodney.id.au \
--cc=amcnabb@mcnabbs.org \
--cc=benh@kernel.crashing.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox