public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: crmafra2@gmail.com
Cc: linux-kernel@vger.kernel.org, reinette.chatre@intel.com,
	linville@tuxdriver.com, torvalds@linux-foundation.org
Subject: Re: [PATCH] iwlwifi: Fix build error in v2.6.25-5561-g064922a
Date: Sun, 27 Apr 2008 23:35:07 -0700 (PDT)	[thread overview]
Message-ID: <20080427.233507.261574307.davem@davemloft.net> (raw)
In-Reply-To: <20080428054700.GA16177@Pilar.virtua.com.br>

From: "Carlos R. Mafra" <crmafra2@gmail.com>
Date: Mon, 28 Apr 2008 02:47:01 -0300

> I've just tried to compile v2.6.25-5561-g064922a and it failed with
> these messages:

Already fixed in net-2.6 by:

commit bd8fd21dfddf51299d782f598cb776b15b7d64cc
Author: Luca Tettamanti <kronos.it@gmail.com>
Date:   Sun Apr 27 15:34:55 2008 -0700

    wireless: Fix compile error with wifi & leds
    
    Fix build error caused by commit
    e82404ad612ebabc65d15c3d59b971cb35c3ff36 ("iwlwifi: Select
    LEDS_CLASS.") from David Miller:
    
    Since MAC80211_LEDS is selected by wireless drivers it must select its
    own dependencies otherwise a build error may occur (kbuild will select
    the symbol regardless of "depends" constraints).
    
    Signed-off-By: Luca Tettamanti <kronos.it@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 520a518..a24b459 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -73,7 +73,9 @@ config MAC80211_MESH
 
 config MAC80211_LEDS
 	bool "Enable LED triggers"
-	depends on MAC80211 && LEDS_TRIGGERS
+	depends on MAC80211
+	select NEW_LEDS
+	select LEDS_TRIGGERS
 	---help---
 	  This option enables a few LED triggers for different
 	  packet receive/transmit events.

  reply	other threads:[~2008-04-28  6:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28  5:47 [PATCH] iwlwifi: Fix build error in v2.6.25-5561-g064922a Carlos R. Mafra
2008-04-28  6:35 ` David Miller [this message]
2008-04-28  7:32   ` Carlos R. Mafra
2008-04-28 13:15     ` Adrian Bunk
2008-04-28 14:21       ` Carlos R. Mafra
2008-04-28 20:58         ` [2.6 patch] iwlwifi: move the selects to the tristate drivers Adrian Bunk
2008-04-28 23:45           ` John W. Linville
2008-04-29  1:07             ` Tomas Winkler
2008-04-30  5:30             ` David Miller
2008-04-30  5:30           ` David Miller
2008-04-30 13:31             ` Carlos R. Mafra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080427.233507.261574307.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=crmafra2@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox