Re: [2.6 patch] iwlwifi: move the selects to the tristate drivers

["Carlos R. Mafra" <crmafra2@gmail.com>]

On Tue 29.Apr'08 at 22:30:54 -0700, David Miller wrote:
> From: Adrian Bunk <bunk@kernel.org>
> Date: Mon, 28 Apr 2008 23:58:49 +0300
> 
> > This patch moves the following select's:
> > - RFKILL        : IWLWIFI_RFKILL -> IWLCORE
> > - RFKILL_INPUT  : IWLWIFI_RFKILL -> IWLCORE
> > - MAC80211_LEDS : IWL4965_LEDS   -> IWLCORE
> > - LEDS_CLASS    : IWL4965_LEDS   -> IWLCORE
> > - MAC80211_LEDS : IWL3945_LEDS   -> IWL3945
> > - LEDS_CLASS    : IWL3945_LEDS   -> IWL3945
> > 
> > The effects are:
> > - with IWLCORE=m and/or IWL3945=m RFKILL/RFKILL_INPUT/MAC80211_LEDS/LEDS_CLASS
> >   are no longer wrongly forced to y
> > - fixes a build error with IWLCORE=y, IWL4965=m
> >   might be a bug in kconfig causing it, but doing this change that is 
> >   anyway the right thing fixes it
> > 
> > Reported-by: Carlos R. Mafra <crmafra2@gmail.com>
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> Applied, thanks a lot Adrian.

Yeah Adrian, thank you very much!

It is really useful for the kernel to have someone like you cleaning 
up these Kconfig mistakes. My dumb patch was not good and now at 
least I know how it should be done.
Keep up your great work!