From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: cooloney@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blackfin checksum annotations
Date: Sun, 27 Apr 2008 06:38:37 +0100 [thread overview]
Message-ID: <20080427053837.GR5882@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080426.222644.74393287.davem@davemloft.net>
On Sat, Apr 26, 2008 at 10:26:44PM -0700, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Sun, 27 Apr 2008 06:22:26 +0100
>
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> Since these are networking knobs and Al tends to test his
> changes, I'll apply this to the net-2.6 tree.
FSVOtest in this case, since I don't have the hardware... However,
all changes seen by gcc are actually
* explicit cast to unsigned short in return expression of functions
returning unsigned short
* csum_fold() return type changed from unsigned int to __sum16
(unsigned short), same as for all other architecture and as net/* expects;
expression actually returned is ((~(sum << 16)) >> 16) with sum being
unsigned 32bit, so it's (a) going to fit into the range of unsigned short
and (b) had been unsigned all along, so no sign expansion mess happened.
IOW, it should not break runtime, but... untested is untested.
next prev parent reply other threads:[~2008-04-27 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 5:22 [PATCH] blackfin checksum annotations Al Viro
2008-04-27 5:26 ` David Miller
2008-04-27 5:38 ` Al Viro [this message]
2008-04-27 11:16 ` Heiko Carstens
2008-04-27 12:42 ` Al Viro
2008-04-27 13:37 ` Bryan Wu
2008-04-27 19:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080427053837.GR5882@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=cooloney@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox