From: Al Viro <viro@ZenIV.linux.org.uk>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: David Miller <davem@davemloft.net>,
cooloney@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blackfin checksum annotations
Date: Sun, 27 Apr 2008 13:42:47 +0100 [thread overview]
Message-ID: <20080427124247.GV5882@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080427111623.GA6754@osiris.boeblingen.de.ibm.com>
On Sun, Apr 27, 2008 at 01:16:23PM +0200, Heiko Carstens wrote:
> I don't think such arch specific patches should go in via net-2.6.
> You did that for a very similar patch for s390 and it was subtly broken:
>
> See:
> f994aae1bd8e4813d59a2ed64d17585fe42d03fc
> ("[NET]: S390 checksum annotations and cleanups.")
>
> and
>
> afbc1e994ddcf3b6fe2dc928ee8dc31a5d0c3118
> ("[S390] Fix TCP/UDP pseudo header checksum computation.")
I remember, and AFAICT this one is safe - here everything stays within
C and type changes ought to be equivalent transformations. Said that,
I do _NOT_ have hardware in question and it's completely untested at
runtime.
Al, who really couldn't care less which tree that goes through - up to
davem and blackfin maintainers; both are on Cc, so...
next prev parent reply other threads:[~2008-04-27 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 5:22 [PATCH] blackfin checksum annotations Al Viro
2008-04-27 5:26 ` David Miller
2008-04-27 5:38 ` Al Viro
2008-04-27 11:16 ` Heiko Carstens
2008-04-27 12:42 ` Al Viro [this message]
2008-04-27 13:37 ` Bryan Wu
2008-04-27 19:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080427124247.GV5882@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=cooloney@kernel.org \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox