From: Ingo Molnar <mingo@elte.hu>
To: Dmitry Torokhov <dtor@mail.ru>,
Stephen Hemminger <shemminger@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: [patch, -git] input: CONFIG_INPUT_APANEL build fix
Date: Wed, 30 Apr 2008 20:54:16 +0200 [thread overview]
Message-ID: <20080430185345.GA27224@elte.hu> (raw)
x86.git testing found this build failure in upstream -git:
drivers/built-in.o: In function `apanel_detach_client':
apanel.c:(.text+0x3027af): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `apanel_probe':
apanel.c:(.text+0x302ac9): undefined reference to `led_classdev_register'
with this config:
http://redhat.com/~mingo/misc/config-Wed_Apr_30_20_22_20_CEST_2008.bad
this driver has a missing CONFIG_NEW_LEDS dependency.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/input/misc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/input/misc/Kconfig
===================================================================
--- linux.orig/drivers/input/misc/Kconfig
+++ linux/drivers/input/misc/Kconfig
@@ -43,7 +43,7 @@ config INPUT_M68K_BEEP
config INPUT_APANEL
tristate "Fujitsu Lifebook Application Panel buttons"
- depends on X86 && I2C && LEDS_CLASS
+ depends on X86 && I2C && LEDS_CLASS && NEW_LEDS
select INPUT_POLLDEV
select CHECK_SIGNATURE
help
next reply other threads:[~2008-04-30 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 18:54 Ingo Molnar [this message]
2008-04-30 19:04 ` [patch, -git] input: CONFIG_INPUT_APANEL build fix Dmitry Torokhov
2008-04-30 20:20 ` Ingo Molnar
2008-04-30 20:56 ` Roman Zippel
2008-04-30 22:21 ` Dmitry Torokhov
2008-04-30 21:00 ` Dmitry Torokhov
2008-04-30 21:20 ` Ingo Molnar
2008-04-30 22:26 ` Dmitry Torokhov
2008-04-30 22:38 ` Ingo Molnar
2008-04-30 22:47 ` Dmitry Torokhov
2008-05-01 0:51 ` Roman Zippel
2008-05-01 2:36 ` Dmitry Torokhov
2008-05-01 6:25 ` Jan Engelhardt
2008-05-01 1:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430185345.GA27224@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox