Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, Apr 30, 2008 at 11:20:29PM +0200, Ingo Molnar wrote:
> 
> * Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> 
> > I thought the many years old rule for Linux kernel is to fix the 
> > issues properly and not turn kernel into patchwork of crappy code.
> 
> correct, except if that would mean breakage for users.
> 
> > If we want to fix the randconfi issue I'd rather revert commit 
> > 66242f7ec531953fbc2f4040c5ffe1f1ffe6c5c9 for now (they only thing it 
> > did was beautify menuconfig look) and wait for Kconfig to be fixed. It 
> > is not driver's task to track through all dependencies.
> 
> yep ... just dont export our internal crappiness to testers and users.
> 

So is there objections to reverting the commit above? This will
fix all drivers that are now depend on LEDS_CLASS bit not specify
NEW_LEDS dependency directly?

> i'm not suggesting this is your fault in any way - but nevertheless many 
> other subsystems have to deal with the same Kconfig issues and they 
> manage to limp along.
> 

I believe I see a steady stream of breakage for leds dependencies
from all subsystems.

-- 
Dmitry