Re: + git-net-git-rejects.patch added to -mm tree

Re: + git-net-git-rejects.patch added to -mm tree

[David Miller]

From: akpm@linux-foundation.org
Date: Mon, 05 May 2008 12:05:40 -0700

> Subject: git-net-git-rejects
> 
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

What happened here?

Did you apply Ingo's IRDA build fixup patches, like I did, and clean
them up or change them in some way?

Re: + git-net-git-rejects.patch added to -mm tree

[Andrew Morton]

On Mon, 05 May 2008 12:51:18 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: akpm@linux-foundation.org
> Date: Mon, 05 May 2008 12:05:40 -0700
> 
> > Subject: git-net-git-rejects
> > 
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> What happened here?

I'm still working out how to incorporate linux-next so I didn't really look
at the actual specfics of this problem.

I noticed that there were rather a lot of changes in
git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git
which are not in linux-next, perhaps due to time lag.

So I generated a diff between linux-next and net-2.6.git using my rather
wonky script to do that.  This script does tend to muck things up
sometimes.

Then on top of origin.patch, linux-next.patch, the above git-net.patch and
this fixup I generated git-net-next.patch from
git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6.git
and that appeared to apply cleanly.

It's all rather complex and I haven't yet got down to working out what's
actually happening.

> Did you apply Ingo's IRDA build fixup patches, like I did, and clean
> them up or change them in some way?

umm, let me see.

No, I think it's a genuine conflict.  linux-next has

commit 01c419104cca3d512a24e160447355487fcfe21c
Author: Bjorn Helgaas <bjorn.helgaas@hp.com>
Date:   Fri Mar 28 10:54:43 2008 -0600

    nsc-ircc: wrap PNP probe code in #ifdef CONFIG_PNP
    
and that conflicts with the irda changes in your tree.



I don't know how that patch got into linux-next.  I thought that Len merged
Bjorn's changes, but that patch doesn't have Len's signoff and that patch
doesn't appear in
git+ssh://master.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git#test

Re: + git-net-git-rejects.patch added to -mm tree

[David Miller]

From: Andrew Morton <akpm@linux-foundation.org>
Date: Mon, 5 May 2008 13:09:11 -0700

> I noticed that there were rather a lot of changes in
> git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git
> which are not in linux-next, perhaps due to time lag.

Andrew, I think you simply have to "let go" of one side or
the other.

If you're going to base on top of linux-next, then let it run
it's course and don't try to suck in the GIT trees on top
of that which linux-next takes already.

Re: + git-net-git-rejects.patch added to -mm tree

[Andrew Morton]

On Mon, 05 May 2008 14:04:50 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Mon, 5 May 2008 13:09:11 -0700
> 
> > I noticed that there were rather a lot of changes in
> > git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git
> > which are not in linux-next, perhaps due to time lag.
> 
> Andrew, I think you simply have to "let go" of one side or
> the other.
> 
> If you're going to base on top of linux-next, then let it run
> it's course and don't try to suck in the GIT trees on top
> of that which linux-next takes already.

It could be that this is what I end up doing - I just don't know yet.

One downside of the linux-next lag is that I can end up merging patches
which others have already merged (more than usual).

I'm still working these things out..