public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	Jon Masters <jonathan@jonmasters.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: changeset: Make forced module loading optional
Date: Mon, 5 May 2008 14:55:02 +1000	[thread overview]
Message-ID: <200805051455.02723.rusty@rustcorp.com.au> (raw)

Linus's recent commit said:
> The kernel module loader used to be much too happy to allow loading of
> modules for the wrong kernel version by default. For example, if you
> had MODVERSIONS enabled, but tried to load a module with no version
> info, it would happily load it and taint the kernel - whether it was
> likely to actually work or not!
...
> Especially as it happened to me by mistake (ie regular unversioned Fedora
> modules getting loaded) causing lots of strange behavior.

Hi Linus,

   I'm trying to figure out how you did this.  So fedora builds unversioned 
modules, and version (and vermagic) matched your kernel?  And you somehow 
mixed them up?

   I don't think relying on modversions is the complete answer here.  Perhaps 
we should make modules_install blow away old modules?

Cheers,
Rusty.

             reply	other threads:[~2008-05-05  4:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05  4:55 Rusty Russell [this message]
2008-05-05  5:05 ` changeset: Make forced module loading optional Linus Torvalds
2008-05-05  5:35   ` Rusty Russell
2008-05-05 17:07     ` Linus Torvalds
2008-05-05 18:42       ` Rusty Russell
2008-05-05 19:47         ` David Miller
2008-05-05  6:43   ` Jan Engelhardt
2008-05-05 14:37     ` Linus Torvalds
2008-05-05 14:50       ` Jeff Garzik
2008-05-05 15:01         ` Linus Torvalds
2008-05-05 15:08           ` Linus Torvalds
2008-05-05 15:32     ` Dave Jones
2008-05-05 15:48       ` Linus Torvalds
2008-05-05 16:01       ` Jan Engelhardt
2008-05-05 15:57         ` Alan Cox
2008-05-05  6:35 ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805051455.02723.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=jonathan@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox