From: Jean Delvare <khali@linux-fr.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
i2c@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] I2C: SiByte: Correct a comment about frequency
Date: Sun, 11 May 2008 11:05:10 +0200 [thread overview]
Message-ID: <20080511110510.4d0d1c8e@hyperion.delvare> (raw)
In-Reply-To: <Pine.LNX.4.55.0805110302400.18978@cliff.in.clinika.pl>
On Sun, 11 May 2008 03:10:29 +0100 (BST), Maciej W. Rozycki wrote:
> The frequency may have been once hardcoded to 100kHz, but currently it is
> passed as an argument to i2c_sibyte_add_bus(), so update the comment to
> match code. While at it, reformat a nearby comment for consistency. No
> functional changes.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> It should be obvious. Please apply.
>
> Maciej
>
> patch-2.6.26-rc1-20080505-sibyte-i2c-add-bus-16
> diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c
> --- linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c 2008-05-05 02:55:25.000000000 +0000
> +++ linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c 2008-05-11 01:14:30.000000000 +0000
> @@ -136,10 +136,10 @@ int __init i2c_sibyte_add_bus(struct i2c
> {
> struct i2c_algo_sibyte_data *adap = i2c_adap->algo_data;
>
> - /* register new adapter to i2c module... */
> + /* Register new adapter to i2c module... */
> i2c_adap->algo = &i2c_sibyte_algo;
>
> - /* Set the frequency to 100 kHz */
> + /* Set the requested frequency. */
> csr_out32(speed, SMB_CSR(adap,R_SMB_FREQ));
> csr_out32(0, SMB_CSR(adap,R_SMB_CONTROL));
>
Applied, thanks.
--
Jean Delvare
prev parent reply other threads:[~2008-05-11 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 2:10 [PATCH] I2C: SiByte: Correct a comment about frequency Maciej W. Rozycki
2008-05-11 9:05 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080511110510.4d0d1c8e@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox